diff --git a/.llm/runs/fix-fresh-malformed-csrf-cookie--issue-2632/context-pack.md b/.llm/runs/fix-fresh-malformed-csrf-cookie--issue-2632/context-pack.md new file mode 100644 index 0000000000..8a1446ec5a --- /dev/null +++ b/.llm/runs/fix-fresh-malformed-csrf-cookie--issue-2632/context-pack.md @@ -0,0 +1,13 @@ +# Context pack + +Issue #2632, draft PR #2640. Base b0eb079575968e843b781579673c9fe2ae250e07. +Implementation and regression tests complete. Tests failed on main (10 failures) and pass after the fix (20/20). Scoped check/lint/fmt, quality:gate, release:preflight, docs:accuracy and JSR audit pass. +Full package doc lint reports 47 diagnostics in unchanged surfaces; form entrypoint has zero. +Next: independent IMPL-EVAL, resolve findings, update body evidence, ready-for-review transition, verify required head checks and review-thread gate. +No merge, auto-merge, status:ready-merge or publication. Keep public artifacts free of operator paths and session IDs. + +Independent IMPL-EVAL PASS: https://github.com/rickylabs/netscript/pull/2640#issuecomment-6922841910. Evaluator independently reproduced 10 failures before the reader change and 20/20 focused plus 315/315 Fresh source tests after it. Full doc-lint diagnostic distribution matches the base exactly. Refreshed the one-line public reference summary as requested. Source implementation is unchanged since evaluation. CI path policy will run scaffold/static/runtime and Fresh browser tiers after ready_for_review despite local CLI E2E being outside this parser fix's gate selection. + +CI quality follow-up regenerated the prose carrier for the changed reference sentence. Only the Fresh reference page and derived llms-full change after decoding. Corpus freshness and release preflight pass under pinned Deno 2.9.7. Push refreshes CI; final head checks still need verification. + +Required CI also checks the MCP export-surface corpus generated from JSDoc. Refreshed the generated carrier with the canonical tool; final head CI remains pending. diff --git a/.llm/runs/fix-fresh-malformed-csrf-cookie--issue-2632/drift.md b/.llm/runs/fix-fresh-malformed-csrf-cookie--issue-2632/drift.md new file mode 100644 index 0000000000..c0caba33c1 --- /dev/null +++ b/.llm/runs/fix-fresh-malformed-csrf-cookie--issue-2632/drift.md @@ -0,0 +1,6 @@ +# Drift + +- Environment: rtk and rg are unavailable; use direct commands and focused find/grep. +- Commands already execute as the node user. Deno 2.9.5 does not accept `deno task --user`; agentic:matrix succeeds as node without that flag. +- The owner selected the existing Sol xhigh implementation session; the simple row's low implementation default does not replace that session. +- Full package doc-lint reports 47 diagnostics in unchanged public surfaces; the changed form entrypoint passes. No broad documentation refactor is included in the parser fix. diff --git a/.llm/runs/fix-fresh-malformed-csrf-cookie--issue-2632/evaluate.md b/.llm/runs/fix-fresh-malformed-csrf-cookie--issue-2632/evaluate.md new file mode 100644 index 0000000000..e48ddc4184 --- /dev/null +++ b/.llm/runs/fix-fresh-malformed-csrf-cookie--issue-2632/evaluate.md @@ -0,0 +1,140 @@ +# Evaluation: PR #2640 — issue #2632 (malformed form CSRF cookie) + +## Metadata + +| Field | Value | +| -------------- | ---------------------------------------------------------------- | +| Run ID | `fix-fresh-malformed-csrf-cookie--issue-2632` | +| Target | PR #2640, head `d0f5f0baeda86e848d5094ab3c8abb6bdc4d01da` | +| Baseline | `b0eb079575968e843b781579673c9fe2ae250e07` (origin/main) | +| Archetype | 4 — Public DSL / Builder (`packages/fresh`) | +| Scope overlays | frontend | +| Workload tier | simple | +| Evaluator | separate session, 2026-11-16; route `minimax_m3@provider_default` on the OpenCode Go transport; generator was Codex `gpt-6.1-sol` (different vendor family, different session) | + +Route selection was read from the pinned Harness matrix (`deno task agentic:matrix --tier simple --impl-evaluator`): simple-tier IMPL-EVAL primary `minimax_m3@provider_default`, fallback `deepseek_v4_flash@provider_default`. The observed evaluator identity matched the requested primary route, so no fallback was used. + +## Process Verification + +| Check | Result | Evidence | +| -------------------------------------- | ------ | --------------------------------------------------------------------------- | +| Plan-Gate passed before implementation | PASS | `worklog.md` records `PLAN-EVAL: N/A` with a concrete reason (bounded parser correction; no new public contract) before implementation | +| Design section exists in worklog | PASS | `worklog.md` `## Design` — public surface, domain, ports/constants, contributor path | +| Commit slices match design plan | PASS | 2 commits: `ce62cb3eb` (plan/bootstrap), `d0f5f0bae` (reader correction + regressions) | +| Each slice has a passing gate | PASS | Focused test 20/20, scoped check/lint/fmt 0, `quality:gate` 0, `release:preflight` 0, `docs:accuracy` 0, JSR audit 0 — all re-run independently below | +| No speculative seams (unused files) | PASS | Diff adds no file; 3 files touched, all consumed by the fix or its tests | +| Constants used for finite vocabularies | PASS | `CSRF_COOKIE_NAME` retained; no new literal vocabulary introduced | + +## Static Gates + +| Gate | Command or check | Result | Evidence | Notes | +| ---------------- | ------------------------------------------------------------------------------ | ------ | ------------------------------------------------------------------------------------- | ----- | +| Narrow typecheck | `run-deno-check.ts --root packages/fresh --ext ts,tsx` | PASS | exit 0, 258 files selected, 0 occurrences | Package-wide | +| Slice typecheck | `run-deno-check.ts --root