Skip to content

Fix skipped LocalizationUtils.detectCultureCode test #94

Description

@brandongregoryscott

There's one test that was added and skipped due to time constraints. I believe the test case itself is valid, and should be accounted for, but the test setup may be incorrect.

The basic idea is:

detectCultureCode should set & return the culture code by priority/validity of the format.

  1. If the culture code is available in the first path index, and it matches the culture code format, use that.
  2. If the culture code is already set as the current culture code, don't change it again - just return it.

https://github.com/AndcultureCode/AndcultureCode.JavaScript.Core/blob/f537b50529ef9c84cce59c1c1f4da1639c101095/src/utilities/localization-utils.test.ts#L264-L279

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions