Skip to content

Add a way to ensure tests actually test something #104939

Description

@jyn514

A common problem I run into with tests is that it's hard to verify they actually do anything. Consider for example #102038: this test had no changes, but before that PR did not actually ensure that the issue didn't reoccur.

We could avoid problems like that by adding a new test annotation, // test-fails-with nightly-YYYY-MM-DD. That will make sure the test actually does something and hasn't always passed.

It will be too expensive to run all those versions on each bors run, so we could instead only run it every 6 weeks before a release (perhaps we can fold this into crater how? at least the automation if not the same codebase.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions