regression: c"..." are experimental

[Mark-Simulacrum]

Not clear to me whether this is expected -- I don't see much in the way of commentary on the RFC, and I thought we had reserved these literals previously, but perhaps that reservation was incomplete?

https://crater-reports.s3.amazonaws.com/beta-1.71-4/beta-2023-06-25/gh/noc7c9.pyfection/log.txt

[fmease]

c"…" inside macro calls (with macro matches like c$e:expr) should definitely continue to compile in editions 2015 and 2018. Those prefixes are only reserved in edition 2021 and onward.

The following reproducer compiles successfully on stable in editions 2015 and 2018 but fails to compile on beta and nightly while it should remain valid:

macro_rules! m { (c$e:expr) => {}; }

fn main() { m!(c"hello"); }

stderr

error: no rules expected the token `c"hello"`
 --> src/main.rs:3:16
  |
1 | macro_rules! m { (c$e:expr) => {}; }
  | -------------- when calling this macro
2 |
3 | fn main() { m!(c"hello"); }
  |                ^^^^^^^^ no rules expected this token in macro call
  |
note: while trying to match `c`
 --> src/main.rs:1:19
  |
1 | macro_rules! m { (c$e:expr) => {}; }
  |                   ^

error[E0658]: `c".."` literals are experimental
 --> src/main.rs:3:16
  |
3 | fn main() { m!(c"hello"); }
  |                ^^^^^^^^
  |
  = note: see issue #105723 <https://github.com/rust-lang/rust/issues/105723> for more information

@rustbot label S-has-mcve

[fmease]

This would be easy to fix if we had access to the edition in rustc_lexer but I don't know if it's acceptable to pass that information to Cursor.
Alternatively, we could unravel CStr and CStrRaw literals into two tokens (Ident and Str / StrRaw) after the fact in rustc_parse::lexer where we have access to the edition, although that's a bit messier I guess (and other parsers like rust-analyzer's would need to remember this step & redo this work).

[hameerabbasi]

Assigning P-medium since this is only a warning, and only valid for older editions of Rust.

@rustbot label -I-prioritize +P-medium

[fmease]

since this is only a warning

@hameerabbasi It's not a warning but a hard error. noc7c9/pyfection no longer compiles due to this bug. rustc lexes the crate differently than before.

[hameerabbasi]

@fmease Do you recommend P-high? Feel free to change the label if so.