Skip to content

Diagnostic doesn't mention cfg'ed out items if the unresolved path is simple (i.e., a single identifier) #132166

Description

@fmease

Given the following code, I would've expected rustc to mention the cfg'ed out item Struct:

#[cfg(flag)]
struct Struct;

fn main() { let _ = Struct; } //~ ERROR cannot find type `Struct` in this scope

but it doesn't:

error[E0425]: cannot find value `Struct` in this scope
 --> file.rs:4:21
  |
4 | fn main() { let _ = Struct; }
  |                     ^^^^^^ not found in this scope

Only if you slightly tweak the input by replacing the simple path Struct with a complex one like self::Struct or crate::Struct, the note "found an item that was configured out" will show up:

#[cfg(flag)]
struct Struct;

fn main() { let _ = self::Struct; }
error[E0425]: cannot find value `Struct` in module `self`
 --> file.rs:4:27
  |
4 | fn main() { let _ = self::Struct; }
  |                           ^^^^^^ not found in `self`
  |
note: found an item that was configured out
 --> file.rs:2:8
  |
2 | struct Struct;
  |        ^^^^^^
note: the item is gated here
 --> file.rs:1:1
  |
1 | #[cfg(flag)]
  | ^^^^^^^^^^^^

CC #109005. I don't know if that's intentional or not.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-cfgArea: `cfg` conditional compilationA-diagnosticsArea: Messages for errors, warnings, and lintsA-resolveArea: Name/path resolution done by `rustc_resolve` specificallyD-terseDiagnostics: An error or lint that doesn't give enough information about the problem at hand.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions