Backtraces don't work during ICE

[mati865]

Backtraces work fine when using panic!() inside crate but they don't when rustc ICEs.

Meta

Backtrace from building Rust with `debuginfo-level = 1`

error: internal compiler error: src\librustc_mir\monomorphize\collector.rs:606: collection encountered polymorphic constant
  --> C:\Users\mateusz\.cargo\registry\src\github.com-1ecc6299db9ec823\compiler_builtins-0.1.25\src\int\mod.rs:50:5
   |
50 |     const ONE: Self;
   |     ^^^^^^^^^^^^^^^^

thread 'rustc' panicked at 'Box<Any>', <::std::macros::panic macros>:2:4
stack backtrace:
   0:         0x67afae48 - _iob_func
   1:         0x67af99b0 - _iob_func
   2:         0x67b3968c - _iob_func
   3:         0x67aed175 - _iob_func
   4:         0x67b08fb4 - _iob_func
   5:         0x67b08c40 - _iob_func
   6:           0xe6f3eb - _iob_func
   7:         0x67b096e0 - _iob_func
   8:          0x1f8df75 - _iob_func
   9:          0x1eaea19 - _iob_func
  10:          0x1eaef52 - _iob_func
  11:          0x2292275 - _iob_func
  12:          0x229386f - _iob_func
  13:          0x2293817 - _iob_func
  14:          0x208c6f3 - _iob_func
  15:          0x208c2a9 - _iob_func
  16:          0x208a98f - _iob_func
  17:          0x208adff - _iob_func
  18:          0x1f722a4 - _iob_func
  19:          0x20894f2 - _iob_func
  20:          0x21298b6 - _iob_func
  21:          0x12411ae - _iob_func
  22:          0x12ba632 - _iob_func
  23:          0x12681f0 - _iob_func
  24:          0x138d820 - _iob_func
  25:          0x1316579 - _iob_func
  26:          0x11084b7 - _iob_func
  27:          0x1196334 - _iob_func
  28:          0x10cbc29 - _iob_func
  29:          0x11d6da7 - _iob_func
  30:           0xf7c788 - _iob_func
  31:           0xe7655c - _iob_func
  32:           0xe73391 - _iob_func
  33:           0xe80fc1 - _iob_func
  34:         0x67b090d7 - _iob_func
  35:           0xf801ae - _iob_func
  36:         0x67af2356 - _iob_func
  37:         0x67aea359 - _iob_func
  38:     0x7ffbf5f27bd4 - _iob_func
  39:     0x7ffbf650ced1 - _iob_func

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.44.0-dev running on x86_64-pc-windows-gnu

note: compiler flags: -Z macro-backtrace -Z save-analysis -Z binary-dep-depinfo -Z force-unstable-if-unmarked -C opt-level=3 -C debuginfo=1 -C linker=clang1 -C prefer-dynamic -C panic=abort -C debug-assertions=no --crate-type lib

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
#0 [collect_and_partition_mono_items] collect_and_partition_mono_items
end of query stack

Backtrace from nightly

error: internal compiler error: src\librustc_mir_build\build\matches\test.rs:417: non_scalar_compare called on non-reference type: impl std::marker::Copy

thread 'rustc' panicked at 'Box<Any>', src\librustc_errors\lib.rs:880:9
stack backtrace:
   0:         0x6e4e7f9b - mingw_set_invalid_parameter_handler
   1:         0x6e51432b - mingw_set_invalid_parameter_handler
   2:         0x6e4d8d15 - mingw_set_invalid_parameter_handler
   3:         0x6e4ec7e1 - mingw_set_invalid_parameter_handler
   4:         0x6e4ec456 - mingw_set_invalid_parameter_handler
   5:         0x63cdedb5 - mingw_set_invalid_parameter_handler
   6:         0x6e4ece85 - mingw_set_invalid_parameter_handler
   7:         0x664647b5 - mingw_set_invalid_parameter_handler
   8:         0x664a18e2 - mingw_set_invalid_parameter_handler
   9:         0x664a0662 - mingw_set_invalid_parameter_handler
  10:         0x65e54e20 - mingw_set_invalid_parameter_handler
  11:         0x65e48d30 - mingw_set_invalid_parameter_handler
  12:         0x65e48cd3 - mingw_set_invalid_parameter_handler
  13:         0x65e54d1f - mingw_set_invalid_parameter_handler
  14:         0x65e54c7d - mingw_set_invalid_parameter_handler
  15:         0x64bc06dc - mingw_set_invalid_parameter_handler
  16:         0x64bc6d2e - mingw_set_invalid_parameter_handler
  17:         0x64bc3a91 - mingw_set_invalid_parameter_handler
  18:         0x64bc1055 - mingw_set_invalid_parameter_handler
  19:         0x64bb945f - mingw_set_invalid_parameter_handler
  20:         0x64bb9a5b - mingw_set_invalid_parameter_handler
  21:         0x64bab77f - mingw_set_invalid_parameter_handler
  22:         0x64bb926f - mingw_set_invalid_parameter_handler
  23:         0x64bb9a5b - mingw_set_invalid_parameter_handler
  24:         0x64bb9a5b - mingw_set_invalid_parameter_handler
  25:         0x64ba6f63 - mingw_set_invalid_parameter_handler
  26:         0x64b727a2 - mingw_set_invalid_parameter_handler
  27:         0x64ba5b80 - mingw_set_invalid_parameter_handler
  28:         0x64ce9818 - mingw_set_invalid_parameter_handler
  29:         0x64e29faf - mingw_set_invalid_parameter_handler
  30:         0x64d4bbbf - mingw_set_invalid_parameter_handler
  31:         0x651937d6 - mingw_set_invalid_parameter_handler
  32:         0x64ceb781 - mingw_set_invalid_parameter_handler
  33:         0x64e2d3e1 - mingw_set_invalid_parameter_handler
  34:         0x64d33c16 - mingw_set_invalid_parameter_handler
  35:         0x6508c4df - mingw_set_invalid_parameter_handler
  36:         0x64ce98e8 - mingw_set_invalid_parameter_handler
  37:         0x64e38cbf - mingw_set_invalid_parameter_handler
  38:         0x64d321ef - mingw_set_invalid_parameter_handler
  39:         0x6508cab0 - mingw_set_invalid_parameter_handler
  40:         0x64cea128 - mingw_set_invalid_parameter_handler
  41:         0x64e2eb0d - mingw_set_invalid_parameter_handler
  42:         0x64d27c13 - mingw_set_invalid_parameter_handler
  43:         0x650c81d4 - mingw_set_invalid_parameter_handler
  44:         0x64057538 - mingw_set_invalid_parameter_handler
  45:         0x64096cff - mingw_set_invalid_parameter_handler
  46:         0x6407236d - mingw_set_invalid_parameter_handler
  47:         0x64058af4 - mingw_set_invalid_parameter_handler
  48:         0x63fc1e60 - mingw_set_invalid_parameter_handler
  49:         0x64055395 - mingw_set_invalid_parameter_handler
  50:         0x63cf76ab - mingw_set_invalid_parameter_handler
  51:         0x63e2fd24 - mingw_set_invalid_parameter_handler
  52:         0x63cf9b41 - mingw_set_invalid_parameter_handler
  53:         0x63e669d6 - mingw_set_invalid_parameter_handler
  54:         0x63e3b4e0 - mingw_set_invalid_parameter_handler
  55:         0x63ce5a8c - mingw_set_invalid_parameter_handler
  56:         0x63e70701 - mingw_set_invalid_parameter_handler
  57:         0x63cea8b1 - mingw_set_invalid_parameter_handler
  58:         0x63e3d75a - mingw_set_invalid_parameter_handler
  59:         0x6e4c8b06 - mingw_set_invalid_parameter_handler
  60:         0x6e4fb7fc - mingw_set_invalid_parameter_handler
  61:     0x7ffbf5f27bd4 - mingw_set_invalid_parameter_handler
  62:     0x7ffbf650ced1 - mingw_set_invalid_parameter_handler

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.44.0-nightly (94d346360 2020-04-09) running on x86_64-pc-windows-gnu

query stack during panic:
#0 [mir_built] building MIR for
#1 [unsafety_check_result] unsafety-checking `main`
#2 [mir_const] processing `main`
#3 [mir_validated] processing `main`
#4 [mir_borrowck] borrow-checking `main`
#5 [analysis] running analysis passes on this crate
end of query stack
error: aborting due to previous error

[mati865]

@rustbot modify labels: +O-windows-gnu

[alexcrichton]

My guess is that this is highly likely to be caused by rust-lang/backtrace-rs#333. Dynamic libraries are not found by backtrace-rs at this time and symbolicated at all. Currently I don't know how to iterate over loaded libraries and register what address ranges they occupy.

[mati865]

@spastorino this might be something for wg-prioritization to talk about.

[spastorino]

@mati865 do you want wg-prioritization to prioritize this issue? or do you want to nominate it for discussion on a T-compiler meeting?. Feel free to tag it with I-prioritize if this needs to be prioritized or with I-nominate if you want to nominate it for discussion.

[mati865]

@spastorino I just want "increase visibility" of this issue hoping that somebody who knows about this stuff would step in. Sorry if that was "wrong address".

[spastorino]

@mati865 not at all, it's not the wrong address, I'm trying to understand how can we help. If you consider this issue important and want to increase its visibility, you can nominate the issue for discussion on the next T-compiler meeting by labelling with I-nominate. If you do so, please explain why you're nominating it. The wg checks all nominations before the meeting and evaluate them in terms of the existing agenda.

[mati865]

@spastorino thank you for the explanation, although I don't think I can use I-nominated label.

@rustbot modify labels: +I-nominated

Reason for nomination:
Rustc ICE backtraces are totally broken on windows-gnu (Tier 1) platform.
This not only makes life harder for people developing Rust using windows-gnu toolchain but also makes backtraces provided by the users completely useless (example here #73114).
Is there anybody who knows enough about Windows unwinding enough to assist here? Or in the other case could you announce something like "call for help"?

[rustbot]

Error: Label I-nominated can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

[spastorino]

@rustbot ping windows

[rustbot]

Error: This team (windows) cannot be pinged via this command;it may need to be added to triagebot.toml on the master branch.

Please let @rust-lang/release know if you're having trouble with this bot.

[spastorino]

Ohh right, there are still some pending PRs to be able to ping windows notify group. Doing so manually for now ...

cc @arlosi @danielframpton @gdr-at-ms @kennykerr @luqmana @lzybkr @retep998 @rylev @sivadeilra