Skip to content

Bootstrap: Initialized submodules no longer eagerly updated by running x.py #99083

Description

@bjorn3

maybe_update_submodules should already do this, but

rust/src/bootstrap/lib.rs

Lines 628 to 635 in c4693bc

let mut bootstrap_submodules: Vec<&str> = vec![
"src/tools/rust-installer",
"src/tools/cargo",
"src/tools/rls",
"src/tools/miri",
"library/backtrace",
"library/stdarch",
];
hasn't been kept in sync with the removal of identical functionality from x.py. Also rust-analyzer is only updated when vendoring is enabled.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C-bugCategory: This is a bug.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions