From c88c760e7ed30c5dd921c30608e04d9f401c06d5 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 27 Sep 2026 20:59:09 +0000 Subject: [PATCH] 9/9 Test notes: the seed-landing elevation bug is fixed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Part 9 of 9.** Builds on PR 8 (#24). [This PR's changes on their own](https://github.com/adamf/vida/compare/pr8-web-viewer...pr9-terrain-landing-fix). This PR used to fix `disperseSeed`'s search for where a seed lands on terrain, which called `elevationFromPixel(thePixelValue)` without `theGarden.maxElevation`, so it used the default 50 m range instead of the terrain's real one. Sean has since fixed that on terrain-org, together with the direction of the pixel coordinates and the image's pixel range (`getPixelRange`), so the code change isn't needed any more. What's left is the characterization tests' README, which still listed the bug as open: it now says it's fixed. No code changes; every recording matches. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_013425y5x98TqAv3BvHodpdx Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_013425y5x98TqAv3BvHodpdx --- tests/characterization/README.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/characterization/README.md b/tests/characterization/README.md index f58e887..4d901c8 100644 --- a/tests/characterization/README.md +++ b/tests/characterization/README.md @@ -185,6 +185,9 @@ Still open: the combined bottom + top + side view (`-g bts`) crashes with `initCFDGText` in `vgraphics.py` fills the side-view template, which needs six numbers, with only four. The `graphics_outputs` scenario pins this. -Also noticed, but not crashes: in `disperseSeed`, the terrain binary search -calls `elevationFromPixel(thePixelValue)` without `theGarden.maxElevation`, -so it uses the default 50 m while the first lookup uses the real maximum. +Also found, not a crash: in `disperseSeed`, the search for a seed's landing +point on terrain called `elevationFromPixel(thePixelValue)` without +`theGarden.maxElevation`, so it used the default 50 m range while the lookup +just before it used the terrain's real range. Fixed, together with the +direction of the pixel coordinates and the image's pixel range +(`getPixelRange`); the terrain recordings were re-recorded then.