From 15af03a53a6e7e08e14a904d53caf5345a5d263e Mon Sep 17 00:00:00 2001 From: Bhupesh Cholake Date: Sat, 7 Nov 2026 01:14:14 +0530 Subject: [PATCH 1/2] fix: insert replacement separators literally Use a callback for whitespace replacement so dollar patterns are not expanded by String.replace. Developed with AI assistance. Assisted-by: LLM LLM: gpt-6-luna --- slugify.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slugify.js b/slugify.js index dd13ebf..288b54d 100644 --- a/slugify.js +++ b/slugify.js @@ -52,7 +52,7 @@ // Replace spaces with replacement character, treating multiple consecutive // spaces as a single space. - slug = slug.replace(/\s+/g, replacement); + slug = slug.replace(/\s+/g, function () { return replacement }); if (options.lower) { slug = slug.toLowerCase() From ae6396655c40b4d2001586ba968b972e61bb99c5 Mon Sep 17 00:00:00 2001 From: Bhupesh Cholake Date: Sat, 7 Nov 2026 01:14:43 +0530 Subject: [PATCH 2/2] test: cover literal dollar-pattern separators Check object and shorthand separators, whitespace runs, strict/lower and untrimmed boundaries. Developed with AI assistance. Assisted-by: LLM LLM: gpt-6-luna --- test/slugify.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/test/slugify.js b/test/slugify.js index 356c4b7..31f7ffb 100644 --- a/test/slugify.js +++ b/test/slugify.js @@ -50,6 +50,20 @@ describe('slugify', () => { t.equal(slugify('foo bar baz', {replacement: ''}), 'foobarbaz') }) + it('options.replacement - literal dollar patterns', () => { + var replacements = ['$&', '$$', '$`', "$'", '$1', 'x$&y', '-'] + replacements.forEach((replacement) => { + t.equal(slugify('foo bar baz', {replacement}), + 'foo' + replacement + 'bar' + replacement + 'baz') + t.equal(slugify('foo bar', replacement), 'foo' + replacement + 'bar') + t.equal(slugify('foo \t\n bar', {replacement}), 'foo' + replacement + 'bar') + }) + t.equal(slugify(' FOO! BAR? ', {replacement: '$&', strict: true, lower: true}), + 'foo$&bar') + t.equal(slugify(' foo bar ', {replacement: '$$', trim: false}), + '$$foo$$bar$$') + }) + it('options.remove', () => { t.equal(slugify( 'foo *+~.() bar \'"!:@ baz',