SUGGESTION: Critical ambiguity in Symbol/Period declaration

[celestynuno-cmyk]

Hi @amusleh-spotware-com ,

I noticed a redundancy in Symbol and Period declarations that can lead to user error.

My Findings:

• Declaration: Values can be set via Environment Variables OR .cbotset files, which is okay.
• Double Declaration: The current image allows conflicting configurations to exist simultaneously within .cbotset and as Environment Variables.
• Hierarchy: In case of double declaration, .cbotset takes precedence without warning.

My Suggestion:

• Atomic Configuration: The .cbotset file should always contain both or none of these variables.
• Mutual Exclusivity: If .cbotset has values, declaring them as Environment Variables should not be allowed. The container should fail to start, throwing a configuration error.
• Fallback: If .cbotset is empty, both Environment Variables must be mandatory.

This would prevent users from accidentally running a bot on the wrong symbol/period due to a configuration override.
Am I missing a specific reason for the current logic, maybe?

[amusleh-spotware-com]

Hi @celestynuno-cmyk,

Thanks for your suggestion, we will consider it, maybe in 5.8.

[celestynuno-cmyk]

@amusleh-spotware-com ,

Great. Thanks for the feedback!

[celestynuno-cmyk]

Hi @amusleh-spotware-com ,

I tested 5.8.3-alpha and it looks like the required protection layers when declaring symbol/period twice are now okay.

I only have one remark:
When there is a mismatch for both symbol and period, only a "conflicting" warning for the --symbol is mentioned. I'd also mention the conflict for the --period whenever it is applicable.

To be honest, I don't see the need to pass symbol/period as environment variables since every *.cbotset file already contains this info, unless the intent is to prevent users from overlooking this information if it only remains inside the *.cbotset.

[amusleh-spotware-com]

Hi @celestynuno-cmyk,

We postponed this change, for now we will keep current behavior that preserves the current priority order.

Current priority order is:

0. CommandLineParameter
1. cBot set file
2. Env vars