Pull Requests Draft Status Is Ignored

[sheldonhull]

Just raising this up since I saw draft status is still getting Broombot alerts. Not sure yet where to add this in the code, but want to make sure it was captured as an issue for those that use Draft status.

[thomasrayner]

Hmm, good call out. I wonder if perhaps the right way to deal with drafts is by having a separate setting. Ignore vs different scan intervals vs different warning counts. I can imagine different scenarios where admins would prefer a different behavior for drafts.

[sheldonhull]

@thomasrayner the point of a draft is it's not ready to review, so I'd suggest defaulting to that being ignored, else it could inhibit the benefit of using draft to signify not ready.

In the meantime, do you have any advice on how to detect? I have stalebot running but it's a little disruptive to have it alerting on drafts right now with the team and I couldn't find a way to filter on drafts.

[thomasrayner]

I definitely agree that there should be separate behavior for drafts vs published PRs. Maybe an option to ignore drafts, and also an option to have them "age" at a different rate (to prevent stale drafts from languishing forever)?

I wish I had a better answer for your current problem. When I was putting together the initial spec, I hadn't considered drafts that sit for a while as I always tend to consider drafts to be PRs that are under active development, and would see new commits, discussion, etc. before being published. Obviously my perspective is limited to my own experiences and the case you're describing slipped through.