Skip to content

Question about the current implementation of mobility regularity-aware loss #6

Description

@mengcz13

https://github.com/FIBLAB/MoveSim/blob/93e6837fa318a9e5a3966f5267accfb303ed8bb6/code/main.py#L165

Is the current implementation of mobility regularity-aware loss correct? Now both $L_d$ and $L_p$ are directly added to the loss for calculating policy gradient, but they won't produce any gradient on the input (generated sequences, since they are discrete values).

I guess the correct way is to add them to the reward instead. Is that right?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions