Repository navigation
fix(ci): refresh apt lists and re-key the apt cache that was saved empty - #103
Merged
Merged
Conversation
cache-apt-pkgs-action caches whatever it installed, including nothing. On 2026-10-04 a run whose apt lists were stale got 404s and saved an empty cache under version 1.0; every Linux job since restores it and skips the install, so main is red. Re-key to 1.1, refresh the lists first, and check the GTK3 headers right after the step so the next empty cache fails at its cause.
Review of #103: the refresh step gets a reason so it is not removed as redundant, plus apt retries; the second refresh before NSIS (same job) is gone; cache versions are quoted so a later 1.10 cannot collapse to 1.1; the header check says how to recover from a cache saved empty.
This was referenced Oct 4, 2026
0xMMA
added a commit
that referenced
this pull request
Oct 8, 2026
Main's apt steps (#103) win in both workflows; the branch's own copies of the refresh and GTK3 checks are dropped so each job has one of each. The Wails parts are re-applied on top: beta.25 wails3 with -tags gtk3, gtk3 on Linux test/vet/build, the readelf GTK3 link check, and bindings drift via git status. go.mod/go.sum and the npm lock start from main's and bump only Wails / @wailsio/runtime. Bindings regenerated with beta.25: identical to main's, SetActiveProvider included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main has been red since 2026-10-04 17:38.
awalsh128/cache-apt-pkgs-actionsaved an empty cache under key version1.0(cache 8487341532). Two dependency debs returned 404, apt-fast exited 0 anyway, and the action cached what it had installed, which was nothing. Every Linux job since then restores that cache, skips the install, and fails at the first cgo package. This hits every push run on main, #94, #95 and the Dependabot PRs.build-windowsis skipped too, so there are no Windows artifacts.Change (build-linux.yml, release.yml)
sudo apt-get update -o Acquire::Retries=3before the apt-cache steps. The action never refreshes lists on GitHub runners (only underact); the step now carries a comment saying so.version1.0→"1.1". This is what actually fixes main: the old key keeps restoring the empty cache. Versions are quoted, so a later1.10can't collapse to1.1.pkg-config --exists gtk+-3.0 webkit2gtk-4.1right after the GTK steps. It fails at the cause. It can't prevent a broken save, because the save happens inside the action, so the comment says how to recover: bumpversionorgh cache delete <id>.After merging — reruns will NOT help
A rerun uses the old commit's workflow, which means
version 1.0and the empty cache again. Instead:maininto fix: batch of small UI bugs (#21 #22 #24 #26 #28 #29) #94 and chore(deps): Wails v3 beta.25 — needs Windows smoke test before merge #95. chore(deps): Wails v3 beta.25 — needs Windows smoke test before merge #95 needs a hand merge: git's automatic part doubles the "Check GTK3 headers" steps.@dependabot rebase.gh cache delete 8487341532. main no longer uses that key.1.0. Cut the next release after it.Review
Opus review with review-pr fork. The fix was verified against the action's source at the pinned SHA and the logs of the run that saved the empty cache; CI is green on this PR. Comment, quoting and redundancy findings are addressed. Open, for Michael: on every cache miss the action downloads
apt-fastfrom an unpinned upstream master and runs it with sudo, release jobs included. Pinning the action's SHA doesn't pin that script. Whether to keep the action at all is a separate decision.