Repository navigation
fix(shell): keep the footer separator on the collapse button - #106
Merged
Merged
Conversation
The separator was the footer's top border, and the version row inside the footer only shows when expanded — so the line jumped up on expand and back on collapse. It now belongs to the collapse button; the version sits above it. E2E pins the line's position in both states.
Review of #106: the old check measured the button's top, which never moved, so only the border-width assertion protected anything. Now every top border in the footer is collected and exactly one is expected, at the same y when expanded, collapsed and hover-expanded. Fails on the old CSS, passes 3/3 on the fix.
Owner
Author
|
Windows test build (current main incl. #104 + this fix, CI green, kept until 2026-10-19): |
0xMMA
added a commit
that referenced
this pull request
Oct 8, 2026
Brings in settings atomic writes and settings.Update, provider switching (#104), the dev channel (#107) incl. workflows, the shell footer (#106), Go 1.27 and the CI apt fixes. Conflicts: shell keeps the subscription list and silent-fix guard next to the dev-channel update title; wails service keeps setShortcutPaused next to the dev-channel calls; settings imports ToggleSwitch and SliderModule. Bindings regenerated. E2E settings stubs gain the shortcut fields the backend now returns.
2 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Michael's feedback: with the sidebar expanded, the version shows and the horizontal separator jumps up, which looks odd. Put the version above the separator, so the separator again marks off the collapse/expand button.
border-topon.sidebar-footer, and the version row inside it only shows when expanded. It now sits on.collapse-btn, so the version is above it and the line stays put in both states.shell-menu.spec.ts, footer separator): the line sits on the collapse button and the version above it, and the line keeps the same position when the sidebar collapses. It failed before the fix (0px) and passes after.shell-menu+dark-modespecs 47/47, unit tests green. CSS only, no Go change.