Skip to content
This repository was archived by the owner on Nov 7, 2018. It is now read-only.
This repository was archived by the owner on Nov 7, 2018. It is now read-only.

to improve indexing performance, we should let Elasticsearch do the update #267

Description

@ultrasaurus

To implement nested documents, the current code fetches the whole document from Elasticsearch and then sends an update with a new document. This is highly inefficient, when es has the ability of updating a nested doc:

https://github.com/18F/open-data-maker/blob/dev/lib/data_magic/index.rb#L79-L85

Activity

  1. pkarman commented on Jan 12, 2016

    @pkarman
    Contributor
  2. pkarman commented on Feb 18, 2016

    @pkarman
    Contributor

    I believe this is already implemented. When working on #295 I added a ES_DEBUG env variable and there is no ES fetch being performed. The ES update feature is already being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions