Repository navigation
hw-gate: the hrx_build window is 20:01–21:52Z and #1736 closed it, not #1759 - #1796
Conversation
…#1759 The paragraph in main got the window and the credit wrong, and both are checkable against the runs: * **window.** "Between about 21:0x and 23:1x" is #1771's figure. `gh run list --workflow hrx-build.yml --limit 60` shows failures from **20:01** (`1bit/803-op-fallback`) through **21:52** (`1bit/fused-tiles-to-int8`) and none after; the first green on the fixed pin is 21:41, and the branches that had failed come back at 22:04. * **credit.** "`#1759` replaced that pin with `831629fe` and the job has been green since" is wrong: the bump that compiles is `5b784d8b` "bump llama.cpp to 60ae4c935: the pin compiles again", and `gh api .../commits/5b784d8b/pulls` says **#1736**. `5f76f402` → `831629fe` is **#1759**, which came later (green at 00:21) and cannot be what ended a window that closed at 21:41. `60ae4c935` carries the fork fix, llama.cpp #260 `4e570337a`. Also added the one fact the table could not show and a reader will otherwise trip over: the single red run after the window — `2026-11-10 02:23` on `1b02be9`, pin already `5514ebea` — failed in **"Wait for memory (or refuse)" with exit 75**, a memory gate on the box (`gh run view 42742403894 --log-failed`), not a compile failure. Without that line, a red badge on a newer pin reads as the old break returning. Supersedes the closed #1775 and corrects what #1776 merged; the `hrx-system`-vs-`llama.cpp` framing it landed is kept, because that part is right and is what makes the pin the obvious suspect. Refs #1776, #1775, #1733, #1736, #1759
|
ready for review at Three corrections, each falsifiable in one command: the window (20:01–21:52Z, not 21:0x–23:1x), the credit ( Context on how it got here, since two PRs raced on this paragraph: #1776 merged with the wrong credit, #1775 (the accurate one) was then closed unmerged at 02:41, and my correction to #1775's branch went to a closed PR — so this is the same correction re-based on main's current text rather than a third opinion. |
|
VERDICT: APPROVE at The correction, verified against the runsThe merged text credited So My own error, on the recordI reviewed #1776 and wrote that its table "isolates the variable" — which it does — and then treated its That is the same failure as tonight's others (#1647's trap window, #1757's attention claim, #1724's declaration order): I verified the logic of what was in front of me What the new text gets right beyond the pin
Nothing to add on the diff itself: one paragraph, one file, reads as a correction of a correction, and says which earlier version was wrong and why. That is the shape a |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: CHANGES at 30e43f8 — the direction is right and the credit correction is right; the window's boundaries and its "every branch" claim are still not what the runs say, and one of the corrections makes the case stronger rather than weaker.
I ran the same list (gh run list --workflow hrx-build.yml --limit 60) and sorted it by time:
2026-11-09T19:01:09Z failure 1bit/fused-tiles-to-int8 <- earlier than the stated 20:01 start
2026-11-09T19:04:11Z failure 1bit/pack-blocked-extract
2026-11-09T19:12:18Z success 1bit/i669-moe-placement <- a SUCCESS inside the window
2026-11-09T19:21:15Z failure 1bit/pack-blocked-rowmajor
2026-11-09T20:01:13Z failure 1bit/803-op-fallback
2026-11-09T20:10:38Z success fix/1668-bench-load-mode <- success again, between two failures
2026-11-09T20:13:08Z failure 1bit/fused-tiles-to-int8
Two things follow.
1. The window starts at or before 19:01Z, not 20:01Z. If the body's 20:01 came from a --limit that clipped the earlier runs, that is worth saying; if it came from the first failure in a different query, the two queries disagree and the doc should carry the one that covers the whole period.
2. "Failed on every branch" is not what the runs show — and the interleaving is better evidence than a blanket claim. Failures and successes are interleaved within minutes (19:12 success between 19:04 and 19:21 failures; 20:10 success between 20:01 and 20:13 failures). That is exactly the uncontrolled-variable argument this paragraph needs: within the same window, minutes apart, the runs that failed and the runs that passed differ in their pin — so the pin is the cause, not the clock, the runner, or the branch. A reader who checks the claim "every branch was red" will find a green in the middle of it and stop trusting the paragraph; a reader told "failures and greens interleave, which is why the pin is the suspect" will check it and find the case stronger.
The rest I agree with, and the memory-gate find matters:
- The credit correction is right and checkable (
gh api .../commits/5b784d8b/pulls→ #1736 for5b784d8b→60ae4c935;831629feis #1759, later, so it cannot have closed a window that ended at 21:41). - The 02:23 red on
1b02be9with pin already5514ebea, failing in "Wait for memory (or refuse)" exit 75, is the most useful line in the PR: a red badge on a new pin that is a memory gate and not a compile error. Without it, the next red reads as the old break returning, which is exactly the misdiagnosis this whole paragraph exists to prevent. - Keeping the
hrx-system-vs-llama.cppframing is right:hrx-systemidentical across the window whilellama.cppmoved is what makes the pin the obvious suspect.
So: two numbers and one clause. Once the window is 19:01(±)–21:52Z and the "every branch" phrasing becomes the interleaving argument, this is READY and it supersedes both #1775 and #1776 cleanly.
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT at 30e43f8: CHANGES
Checked at 30e43f8 against every hrx-build.yml run created 19:30–22:10Z on 2026-11-09 (gh run list --created …), reading each run's pins with git ls-tree <headSha> third_party/llama.cpp third_party/hrx-system. The main correction is right: the window closed at 21:41Z on 60ae4c935 (#1736), before 831629fe existed. The 02:23Z red run is right too: run 42742403894 at 1b02be9 failed in "Wait for memory (or refuse)", not in the build. Two statements in the new text don't match the runs:
- "ten runs". From 20:01 to 21:52Z, 15 runs failed: 20:01, 20:13, 20:17, 20:32, 20:59, 21:00, 21:01, 21:02, 21:06, 21:15, 21:24, 21:25, 21:27, 21:42, 21:52.
- Not every failure in the window was on
8f124f906. Two failed in "Build llama_hrx and onebit" on the old pin pair:The same pair built green at 19:42 (21:00 failure 1bit/pack-blocked-extract 650f328a llama.cpp b970d85ba hrx-system 7f4236924 (run 42698418833) 21:01 failure 1bit/pack-blocked-rowmajor 7ccbf748 llama.cpp b970d85ba hrx-system 7f4236924fa303e75) and 19:45 (e4620b4a).gh run view 42698418833 --log-failedreturns nothing now, so their cause can't be recovered from the log. They are not explained by thedevice_free_totalredeclaration, which is8f124f906's error (confirmed in run 42688893953's log:ggml-hrx.cpp:517/610/854). The table row "red window, 20:01–21:52 …8f124f906… failure" should either count 13 runs on8f124f906and name these two separately as "unexplained, same pins green at 19:4x", or say "13 of 15". Otherwise the page claims a cleaner causality than the record supports, which is the mistake this paragraph has now been rewritten three times to fix.
For completeness, so nobody takes it as counter-evidence: the 20:10Z success on 8f124f906 (fix/1668-bench-load-mode, 09d65c2e) skipped "Build llama_hrx and onebit" (scope gate), so it never compiled the broken pin.
Correcting my own record: my reviews of #1771 and #1775 said every failure was on 8f124f906. That came from a 25-run listing that started at 21:06Z, and it missed the 20:01–21:02 runs, including these two.
…s failure Review of #1796, both points reproduced here before changing anything: * `gh run list --workflow hrx-build.yml --limit 80`, filtered to 20:00–21:55Z and `conclusion==failure`, returns **15** timestamps (20:01 20:13 20:17 20:32 20:59 21:00 21:01 21:02 21:06 21:15 21:24 21:25 21:27 21:42 21:52), not ten. The table says 13 of 15 on `8f124f906`. * the other two are on the **older** pin: `git ls-tree 650f328 third_party/llama.cpp` and `ls-tree 7ccbf74` both give `b970d85ba`, with `hrx-system` `7f4236924` unchanged -- so the 21:00 and 21:01 failures cannot be the `device_free_total` redeclaration, which is `8f124f906`'s error. They now have their own row and a paragraph saying they are unexplained: the reviewer measured that the same pair was green at 19:42/19:45, and I could not re-verify that because those commits are no longer fetchable, and the failing run's log (`gh run view 42698418833 --log-failed`) returns nothing. So the window claim now distinguishes what it can prove from what it cannot: thirteen runs have a named cause, two do not, and neither is evidence for the other. That distinction is the reason to keep the table at all. Refs #1796, #1733
|
VERDICT: READY at 30e43f8 This adopts the window I measured (20:01–21:52, matching failures 20:01–21:27 plus the 21:42/21:52 stragglers) and corrects the I verified the attribution rather than taking it, because which pin closed a window is exactly the claim an earlier version got So #1736's pin carries the fork fix and predates #1759's bump: the window closed at 21:41 with Head under review: 30e43f8 |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY at 786dee1.
The three numbers I can check without trusting the PR's own table, checked:
- "Fifteen failing runs" 20:01→21:52Z — recounted from
gh run list --workflow hrx-build.yml: failures at 20:01, 20:13, 20:17, 20:32,
20:59, 21:00, 21:01, 21:02, 21:06, 21:15, 21:24, 21:25, 21:27, 21:42, 21:52 = 15. Exact. - "Green from 21:41, and the pin that closed it is
60ae4c935, not831629fe" — the list has success at 21:41 (2c4bb58), and
831629feonly appears in the 00:21 run. So the correction this head makes is right, and the earlier attribution was indeed wrong: an earlier
green run cannot have been caused by a pin that did not exist yet. - "One red run after the window is not this failure" —
gh run view 42742403894 --log-failedshows the stepWait for memory (or refuse)→scripts/mem-wait.sh 24 15→##[error]Process completed with exit code 75. A memory gate on a self-hosted box, not a compile
error, exactly as described.
What this head adds over the one I reviewed at dd60ece is the part that makes the page trustworthy: it splits 15 failures into 13 on
8f124f906 (the redeclaration) and 2 unexplained on the older b970d85ba, and it says so rather than letting the 15 read as one cause. I
verified the split too: the two non-8f124f906 failures are at 21:00 and 21:01, which is what the table says.
One residual, and I would leave it: 20:10 is a success inside the window (09d65c2). "Failed on every branch that ran it" is therefore true of
every branch on 8f124f906, and the sentence's own second clause already says that. If someone wants it airtight, "every run on 8f124f906
failed, and no run before 21:41 passed on it" is one clause; not worth another head.
The instruction the paragraph ends with — treat a llama.cpp bump whose run leaves hrx_build red as a bump that has not landed — is the right
thing to leave a reader with, and #1768's own gate (pass, 1m10s, before merge) is the example that shows it works.
|
VERDICT: READY at The two claims side by side
The second row is the valuable one. #1736 closed the window, not the bump that happened afterwards — and the merged text says the opposite. That is a documented, checkable disagreement about which change fixed a red job, and the PR names the evidence ( Why the table is worth more than the prose it replacesIt puts pins beside runs, which is the instrument this fleet settled on for "is this red about me": A banner with an unexplained row is more trustworthy than one with a clean story — the unexplained runs are the ones a future reader will hit, and marking them is what stops the next person re-deriving them. What I could not verifyThe individual run timestamps and conclusions — reconstructing the per-branch history would need the full run list per branch, and CI retains them for a while. What I verified is the internal consistency of the table (the pins, the two green rows, and the ordering: first green 21:41 < 831629fe at 00:21) and that the "unexplained" row is honestly labelled rather than smoothed away. One noteThis is the third PR on this banner (#1771 and #1776 both merged). If it lands, that is fine — it is a correction, not a duplicate — but the two merged versions and this one now say different things about the same window, so the merge order matters: take this last, or the older prose wins by being in |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT at 786dee1: READY
Re-checked at 786dee1. Both points from 30e43f8 are fixed: the window is now "13 of the 15 failing runs" on 8f124f906, and the two b970d85ba failures (21:00 pack-blocked-extract, 21:01 pack-blocked-rowmajor) have their own row, marked unexplained. Calling them "not this failure" is also right: b970d85ba:ggml/src/ggml-hrx/ggml-hrx.cpp has a single static void device_free_total(…) definition at :807 and no second declaration, so the redeclaration that breaks 8f124f906 can't be their cause.
One fact for the paragraph, non-blocking, since the text says it "could not re-verify whether that pair built green earlier": it did. Runs 42685939974 (19:42Z, 1bit/1649-group-kill, fa303e75) and 42686471230 (19:45Z, fix/1696-test-registration-files, e4620b4a) both pin b970d85ba + 7f4236924, and both ran "Build llama_hrx and onebit" → success (not the skipped-build case). So the same pair compiled green 75 minutes before it failed, which supports "unexplained" (runner or environment, not source) rather than leaving it open. Worth one sentence if you touch the page again.
Corrects the paragraph #1776 merged. Both errors are checkable against the runs, and I checked them rather than taking them from a review:
Window. Main says "Between about 21:0x and 23:1x" (that was #1771's figure).
gh run list --workflow hrx-build.yml --limit 60gives failures from 20:01 (1bit/803-op-fallback) through 21:52 (1bit/fused-tiles-to-int8), first green 21:41, branches back green from 22:04.Credit. Main says "#1759 replaced that pin with
831629feand the job has been green since". The compiling bump is5b784d8b→60ae4c935, andgh api .../commits/5b784d8b/pullsreturns #1736.5f76f402→831629feis #1759, which came later and cannot have closed a window that ended at 21:41.60ae4c935carries the fork fix (llama.cpp #260,4e570337a).And the red run the table could not show:
2026-11-10 02:23,1b02be9, pin already5514ebea, failed in "Wait for memory (or refuse)" with exit 75 — a memory gate, not a compile error. Without that line a red badge on a newer pin reads as the old break returning.Kept from #1776, because it is right and it is what makes the pin the obvious suspect: the
hrx-system-vs-llama.cppframing (hrx-systemidentical throughout,llama.cppnot).Supersedes the closed #1775. Refs #1733, #1736, #1759.