Repository navigation
docs/hrx: the #856 placement table names each row's load mode, since the rows differ in it - #1847
Conversation
…the rows differ in it #1680 merged over a CHANGES verdict at 132c609: the table's two rows differ in placement AND load mode (row 2 is `-lm none`, per #1680's own body), so the visible 3,879 / 3,241 = 1.197x prefill reads as a placement win when most of it is the load mode (1.1745x on its own, #1668). The paragraph below already gives the placement-only number (0.1 %) from the third arm; the table now says why the two rows are not that comparison. Co-authored-by: bong-water-water-bong <bong-water-water-bong@1bit.gg> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
VERDICT: READY at The caveat is the value, not the extra column. "The two rows differ in load mode as well as placement, so their prefill ratio (1.197×) is not a placement result: Three things that make the table trustworthy now:
One thing I would add, cheaply: the row label is "host-placed |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY at cf6aa12 — a retraction of a confounded comparison, which is the most useful kind of docs change a measurement board can carry.
What it fixes: the #856 placement table now says each row's load mode, and states the consequence plainly — "The two rows differ in load mode as well as placement, so their prefill ratio (1.197×) is not a placement result". The old table invited the reader to attribute 1.197× to host placement when the mode (-lm mmap vs -lm none) changed too. Same class as the hrx_build window I reviewed this morning: a number that looked like evidence for one variable when two had moved.
Why keeping the rows is right rather than deleting them: the measurements are real, only the attribution was wrong; naming the mode per row preserves what was observed and removes the false inference. That is better than dropping the table, which would lose the observation.
Not verified: the numbers themselves (device work, npu-hold/gpu-hold; the box is mid-build and this is a docs change). What a review can check is that the claim and the table now agree, and they do.
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT at cf6aa12: READY
The #856 placement table gains a load mode column, so each arm now says which residency it ran in next to its BO bytes, peak GTT and prefill number. That is the right column to add to this table: the arms differ in where the weights live, and without the mode the three numeric columns are comparable-looking measurements of different things — the same trap the tokens/sec tables have carried all night.
Docs-only and additive: the existing rows keep their numbers, and the column makes the mode explicit rather than implied by the row's label.
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY at cf6aa12a — and the paragraph that makes it trustworthy is the one about the table's own confound:
"The two rows differ in load mode as well as placement, so their prefill ratio (1.197×) is not a placement result: -lm none alone is 1.1745× prefill on the same file and shape (#1668). The third arm holds the load mode fixed, and that is the placement number quoted below."
That is the single most valuable habit in this fleet's measurement culture: naming which rows are confounded before quoting a number, and citing the control that isolates it. Naming each row's load mode in the table header is the structural version of the same fix — with -lm mmap and -lm none in the columns, nobody can read a placement ratio off a load-mode comparison again.
One note: the table now carries BO bytes, own peak GTT and prefill per arm, which is good, but the units of "own peak GTT" versus a per-process GTT total elsewhere in the docs differ. One clause saying "own = this arm's allocation, not the device total" would stop the two being compared directly by someone reading both pages.
Follow-up from the audit of PRs merged over a CHANGES verdict (
~/briefs/MERGED-OVER-CHANGES-2026-11-10.md, row #1680). Refs #856, #1668.The defect on main: #1680 merged with a CHANGES verdict at
132c609. That verdict's point still holds indocs/hrx.md: the table's second row is-ot 'ffn_down\.weight=CPU' -lm none(from #1680's own body), and the first row is the default-lm mmap. So the visible 3,879 / 3,241 = 1.197× prefill looks like a placement result, but-lm nonealone is 1.1745× on the same file and shape (#1668's ABBA, where A is the default-lm mmap).The change: docs only, one file.
-lm mmap(default) /-lm none).Every number is unchanged and comes from #1680's body or #1668. Nothing was re-measured, so no device was used.
Left alone: the same verdict's non-blocking note on the "numerically free and speed-neutral" kernel sentence is waiting for the owner's call on what public
docs/hrx.mdmay say, so I didn't touch it.🤖 Generated with Claude Code