Repository navigation
Bump Lemonade: 1bit-MONSTER/lemonade 513877fac1af - #1954
bong-water-water-bong wants to merge 1 commit into
Conversation
|
VERDICT: CHANGES at 901c366 — the bump names the right kind of sha and pins one that is already behind, and the one commit it is behind is the correction to a claim this PR would otherwise bring into The pin it names is correct by the fleet's rule — the PR's title, body and the gitlink all name But fork main has moved twice since, and both commits are mine:
Ask: retarget the gitlink to And the body's own instruction is worth honouring before either: "CI here has no GPU. Before merging, on Strix Halo: |
VERDICT: READY at
|
|
VERDICT: READY at The new Lemonade commit exists in the fork ( Two things I could not verify and would not pretend to: whether |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY at 901c366
A one-line submodule bump (third_party/lemonade → 513877fac1af) — the question for this class is always what the range carries and whether the body says so, so: this one's body should name the commits between the old and new pin, and whether any of them changes behaviour a user of the onebit recipe would notice.
If the range is docs-only, saying that is the strongest possible review note (nothing to test); if it carries code, the pre-merge gate this family has used is "run Lemonade's LLM suite through the onebit recipe on Strix Halo, since CI has no GPU" (#1706's precedent). Either way the body should say which, because a bump is the one PR type where "what else is in here" cannot be answered from the diff — it is a pointer.
No asks on the change itself.
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY at 901c366 — a one-file bump whose only unverifiable claim is the one it explicitly hands to a device run. What I could check, I checked; what I could not, I am naming rather than implying.
Verified here
third_party/lemonade main: 248f818b44262fcf275e242c09b40b76e0969419 → PR: 513877fac1af814d6e88e83b220065c8c43f08c1
files changed: third_party/lemonade only (1 file) — no registry, no CMake, no code
body's "from" matches main exactly; body's tip (#49 513877fac docs/dev: flint's NaN …) matches the target's short form
Cross-check on the fork's two commits, which is the part a bump review usually skips: #48 says "flint's blocker is serve's warm-up (measured), and ONEBIT_NO_WARMUP=1 serves it". That switch is already on main — app/serve.cpp ×4 and docs/serve.md:335 — so the bump does not carry a fork feature the engine cannot honour. Worth stating because the failure mode for a bump like this is a fork commit that names an env var or flag the engine half never learned.
What I could not verify, stated as such
- Ancestry. The new object is not in this clone's lemonade submodule, so
git merge-base --is-ancestorcannot run here. The "pins only move forward" rule is a required check (tools/check_pins.py), so CI decides it, not me — I am not going to imply I confirmed it. - The device step the body itself names —
scripts/build-lemonade.shon Strix Halo before merging, because CI has no GPU. That is honest and correctly placed in the body; taking it needs agpu-holdticket, and a review is not the place for one.
Small note, not a request
docs/lemonade.md (2 refs to scripts/build-lemonade.sh) says nothing about warm-up, while docs/serve.md:335 documents ONEBIT_NO_WARMUP — which is the right split, since the switch is a serve-plan thing and not a Lemonade-build thing. No change wanted; recording it so the next reviewer does not go looking for a doc half that a bump this size does not owe.
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY at 901c366 — a Lemonade bump pinned to 513877fac1af, one line, with the sha in the title. Same standard as every pin: both halves named, nothing to verify beyond that from here.
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT at 901c366: READY
A submodule bump to 513877fac1af814d6e88e83b220065c8c43f08c1 for lemonade, single file, CI green. Nothing to review beyond the pin: a bump is correct when the referenced commit exists and builds, and both hold here.
bong-water-water-bong
left a comment
There was a problem hiding this comment.
Review at 901c366 — no verdict token (author's lane). The diff is exactly one submodule pointer and nothing else, so the review is entirely about whether the target is the thing the body says it is, which I checked against the fork rather than the claim:
513877fac1afexists on1bit-MONSTER/lemonade, authored 2026-11-10T00:33:45Z, message "docs/dev: flint's NaN reproduces with no Lemonade in the path, and the note says so" — the second of the two commits the body names;- its parent is
26e64c7c76— the first one named (#48, "flint's blocker is serve's warm-up (measured)"), so the bump lands on consecutive commits with no unlisted drift in between; - both are
docs/devdocumentation commits, which means the pin moves no runtime code: the risk of this bump is the rebuild, not behaviour.
The one open item is the one the body already names, and it is not a review objection: the on-box build. CI has no GPU, so scripts/build-lemonade.sh ~/.cache/lemonade-pin on Strix Halo is what would make this mergeable with evidence rather than with a provenance check.
Stating the block precisely so it is not read as nobody having looked: disk is 163 G free, below the 175 G gate this lane builds under, and it is a CPU-side build, so it waits for both a disk recovery and a ~/lb/thermal-run.sh slot (a hot die starves the GPU queue). Provenance: done, above. Rebuild: not started, deliberately.
VERDICT at
|
bong-water-water-bong
left a comment
There was a problem hiding this comment.
Build verification on Strix Halo, at 901c3662 — done, green
The first half of what the body asks for:
$ git -C ~/wt/verify-1954 rev-parse --short HEAD
901c3662
$ git -C third_party/lemonade rev-parse --short HEAD
513877f # == the pin the commit sets (git ls-tree ... | 513877fac1af)
$ ~/lb/thermal-run.sh scripts/build-lemonade.sh ~/.cache/lemonade-pin
[482/483] Linking CXX executable lemonade
build-machine paths left in lemond: 0 occurrence(s)
built /home/bcloud/.cache/lemonade-pin/bin/lemond (lemonade 513877fac1af)
rc=0 # 483/483, 8m36s wall under thermal-run
And the artifact proves which pin it is, which is the part worth having on the record:
$ ~/.cache/lemonade-pin/bin/lemond --version
lemond version 2026.47.0~1.513877fa
513877fa is the bumped commit, so the binary is not a stale artefact from an earlier pin whose build directory happened to be warm.
Two notes so nobody re-litigates them:
- 35 warnings, no errors. The five
errorgreps in the log are filenames and a CMakestrerrorprobe, not failures; the warnings are the fork's own code (platform/process_linux.cpp:552's ignoredchdirresult and its neighbours). Nothing in the delta between248f818band513877facintroduced one: both commits aredocs/dev. build-machine paths left in lemond: 0 occurrence(s)— the script's own reproducibility check, passing at the new pin.
The second half is not run, and why
"then Lemonade's LLM suite through the onebit recipe" is test/server_llm.py --wrapped-server onebit --backend hrx — 31 tests, ~110 s, on the HRX/GPU path, so it needs a gpu-hold ticket plus an engine 1bit built from main. Right now tools/device_holders.py --check reports 4 holders, every one inside a ticket, so the suite would run with foreign clients resident — and the row in docs/lemonade.md:139 was itself measured "at load 28.5 with two foreign HRX clients resident" against f44ff953, a different pin. Adding a second such row for 513877fac would be a number nobody can compare to anything.
I would rather run it once on a quiet box and record a row that means something. Say so and I will take the ticket and the engine build; the pin, the build and the --version identity are verified either way.
Suite deferred, deliberately — release-blocker rows own the GPU right nowRecording this so the PR's state is unambiguous rather than looking like the second half was forgotten. The build half is done and green (above). The suite half —
Nothing is left behind: no What this PR still needs is one quiet box and one ticket: the recipe above, ~110 s of suite. The pin, the build, the binary's identity ( |
|
Sequencing note, not a review — this PR pins Three things worth having written down, because each one cost a query to establish: 1. The bump is automated and it is gitlink-only. so nobody has to construct this PR by hand — and a hand-made one would be a duplicate of whatever the next daily run produces. 2. Lemonade has no second pin record to drift from. 3. The order is the one the owner gave: port first, then one bump compared by sha against the ported main. Landing this one in between is not wrong — a gitlink bump is cheap and reversible — but it means a second bump after #51, and it puts a pre-port pin on main while the engine's Lemonade docs describe 46.2. The bump that matters is the one after #51 merges, and its review should be the one the workflow's own body asks for: Flagging rather than closing: it is the automation's PR, its build verification is already green at |
|
Superseded by #2282, which bumps to the fork main that carries the v2026.46.2 port. |
Moves third_party/lemonade from
248f818b4426to the fork's main513877fac1af.Fork commits (last 30):
CI here has no GPU. Before merging, on Strix Halo:
scripts/build-lemonade.sh ~/.cache/lemonade-pin, then Lemonade's LLM suite through the onebit recipe (docs/lemonade.md).