Repository navigation
census: DeepseekV4FlashSuperExpertForCausalLM is reviewed and report-only, with the reason recorded (Fixes #1922) - #1972
Conversation
…only (engine#1922) The pack's own config.json settles it two ways: `auto_map` points at its own modeling_ module (remote code, so there is no GGUF architecture for a pinned upstream to accept), and it ships AW-SECD-compressed weights (8.5 GB, claimed 0.962 retention), so nothing at the pin could decode the file even with the architecture mapped. Recorded in significant.json with watch: report, i.e. listed and not alerted. Pinned by four checks in tests/census_watch_test.py: report-only, the reason names the compression rather than just the decline, the class stays out of architectures.json (which is generated from the pin and must not gain a guessed gguf name), and the model_type is recorded. K2HorizonForCausalLM is deliberately NOT added: the repo is gated (401 on both the raw config and the model API), so there is no model_type to record and a reviewed entry would be a claim about a class nobody has read.
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY at ba9f9ee
This is the declined/reviewed state being used exactly as the census now defines it (engine#1929's definitions block: "a human reviewed the class and deliberately did not map it … counted separately and excluded from top_unmapped"), and the mechanism is a "watch": "report" entry with a test asserting it:
check("engine#1922 class is recorded as report-only",
sig.get(_DS, {}).get("watch") == "report")Two things make that the right shape: the class stays listed (so it is not silently dropped from the census), and it stops alerting (so the daily watcher's signal stays worth reading). A reviewed class that keeps alerting is how a watcher gets muted; a reviewed class that disappears is how a decision gets lost.
And the stated reason is the compression, not the novelty — which is the useful kind of decline: "this is a new architecture" would be a reason to look, not a reason to decline. One of the two classes is deliberately left alerting, which is the honest split: reviewed-and-accepted versus not-yet-reviewed are different states and the census now has vocabulary for both.
No asks.
VERDICT at
|
|
VERDICT: READY at Two facts are recorded and both are the kind that decide whether a registry row is honest: remote code (so no architecture string can tell us what the model does — the repo ships its own With #1943 and #1967 landing the same day, the registry now has three separable states — mapped, custom code, declined with a reason — which is what stops an uncovered class from being a silent number. Nothing to change. When this merges, the census JSON's |
|
VERDICT: APPROVE at Right file, existing mechanism
declined_archs = {hf for hf, e in sig.items() if e.get("watch") == "report" and not a_get(archs, …)}so The reasoning is the distinction that matters
Unmapped and unmappable are different states, and only one of them is a gap. A registry row for this class would be a claim the engine cannot honour — the same class of error as the "silent partial output" family this session has been closing: a declaration that is true of the table and false of the software. Report-only is the honest state until something at the pin can decode AW-SECD, and The What is still open on #1922The other For the record on the DeepSeek class: remote code plus a compressed weight format is the hardest combination to serve, because neither half is in the pin — the converter would need the modeling module and the loader would need AW-SECD. Report-only is not a postponement here; it is the accurate description. |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT at ba9f9ee: READY
Registry change plus the test that pins it: DeepseekV4FlashSuperExpertForCausalLM is recorded as reviewed and report-only in registry/significant.json, and tests/census_watch_test.py keeps the classification honest.
That is the disposition path #1929 made explicit (declined = "a human reviewed the class and deliberately did not map it") being used for a real class rather than described in prose. The test is what stops the entry being flipped to mapped without anyone noticing.
CI green.
Fixes #1922(the twoREMOTE-CODEarchitecture classes the daily watcher found), with one measured, one deliberately left alerting.What is recorded, and why the reason is the compression rather than the novelty
shashanth-27xA9/DeepSeek-V4.1-Flash-SuperExpert-8GB/config.jsonsettles it two ways:modeling_module, so there is no GGUF architecture at the pin for it;So it goes in
registry/significant.jsonwithwatch: "report"(listed, not alerted, the rule from #1451), and it does not go inarchitectures.json, whichtools/registry_build.pygenerates from the pin and whose rows must never gain a guessedggufname.K2HorizonForCausalLMis deliberately absentThe repo is gated — 401 on both the raw config and the model API:
No
model_type, no geometry — so awatch: "report"entry would claim a review of a class nobody has read. It stays alerting, which is the honest state; the issue carries a note that its row is blocked on HF access rather than on capacity, so it becomes a five-minute entry when access exists.Measured
The class is silent; the watcher still exits 1 for an unrelated reason — the
vllm-project/semantic-routersupport pin moved yesterday. That is a separate row and I have not touched it: bumping a pin needs someone to read the upstream change first, which is a different job from declining an architecture. Saying so here so nobody reads a green test plus a red watcher as this PR being incomplete.tools/copyright.py --check→ rc=0.