Skip to content

ci: a comment cancels the PR's pr-agent review, because both enter one concurrency group #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bong-water-water-bong merged 1 commit into from
Nov 11, 2026
Merged

ci: a comment cancels the PR's pr-agent review, because both enter one concurrency group #2071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/pr-agent.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,12 @@ jobs:
runs-on: [self-hosted, pr-agent]
# on the job, not the workflow: a comment that skips the job (a bot's, say) must not cancel a review
concurrency:
group: pr-agent-${{ github.event.pull_request.number || github.event.issue.number }}
# A comment and a push are different jobs on one serialised model runner: an `/ask` must not cancel the review of
# the PR it is asked about, and a `synchronize` must cancel the review of the head it replaced. Grouping by event
# name keeps push-cancels-push (right: a newer head makes the older review moot) without letting a busy thread
# starve it. Measured 2026-11-10: PR #2007's review ran 19:21:26 -> cancelled 19:30:31, and `issue_comment:
# [created]` puts every comment on the PR into this same group with `cancel-in-progress: true`.
group: pr-agent-${{ github.event.pull_request.number || github.event.issue.number }}-${{ github.event_name }}
cancel-in-progress: true
timeout-minutes: 30
# same-repo PRs, and comments by the owner, members or collaborators on a pull request
Expand Down
Loading