Repository navigation
Pin: unsloth/Qwen3.8-27B-GGUF - #2284
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT at f731f60: CHANGES
Reviewed at f731f608ab8d2d9262e3568e6f27a8336206f190. It is the pin-watch bump of unsloth/Qwen3.8-27B-GGUF from 4ca72078 to 4af51b35.
Blocking: the bump overwrites the record of the file we hold with upstream's new bytes. docs/model-pins.md says what files is:
files— the files we hold, not the files that happen to be there … because a pin taken after a vendor re-push would otherwise store our older copies under the newer commit and look clean.
This PR changes Qwen3.8-27B-UD-Q4_K_XL.gguf from oid 3f227079…, size 17,559,178,144 to oid 2a5f3565…, size 17,659,407,264. That is upstream's re-quantized file ("New UD3.1 UD-Q4_K_XL", the body's own table). The copy on this box is still the old one:
$ stat -c %s ~/models/qwen38/UD-Q4_K_XL/Qwen3.8-27B-UD-Q4_K_XL.gguf
17559178144
The pin's used_for also names it as the upstream of our 1bit-MONSTER/Qwen3.8-27B-UD-Q4_K_XL-MTP re-host, which was built from those old bytes. After this merge, pins.json would say we hold 2a5f3565… at 4af51b35, and pin_watch.py --check would read clean, while the stick catalogue and the MTP re-host carry 3f227079…. That is the silent case the file exists to prevent, in the other direction.
Two ways to fix it:
- keep what we hold: move
committo4af51b35, keep the file entry at3f227079… / 17,559,178,144, and add the doc's own marker toused_for,"upstream: our copy predates the pinned revision"; or - hold the bump until the UD3.1 quant is actually adopted (catalogue row, stick, MTP re-host), and change the file record in that PR.
The body's own line, "Merging says this is the revision we point at", is right. The files block just has to stay the bytes we point from.
If tools/pin_watch.py --bump is what wrote the new oid into files, that is the defect to fix there, so the next re-quant does not repeat this.
CI build at this head: completed success.
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY -- and the one thing the table shows but does not say is that this is a different artifact, not a moved pin
Checked line by line: exactly one held file changes identity (oid and size removed and re-added), everything else is pinned/commit metadata, and -- the part that matters -- template_sha256 is byte-identical on both sides (12827f24b742…). So prompt rendering and tokenization are unaffected by this bump, which is the half of a model pin that can be checked here.
What the table makes clear, and I would put in words in the body: upstream re-uploaded the quant, it did not move it --
| before | after | |
|---|---|---|
| size | 17,559,178,144 B | 17,659,407,264 B (+100 MB) |
| oid | 3f227079003a… |
2a5f3565f39c… |
| chat template | 12827f24… |
12827f24… (same) |
That is a different set of weights under the same file name. The consequence for this repo is not the pin file -- it is that any weight-level number taken before today describes an artifact that no longer exists: the 27B decode counts in the body of #2241 ("866 -> 850 device copies", "16,181.4 -> 15,718.5 MiB") and anything else measured on Qwen3.8-27B-GGUF now refers to 3f227079003a. Same prompt, same tokenizer, same architecture -- different weights. Worth one sentence in the body saying which numbers need re-taking, because the honest alternative is that someone quotes them against the new file in a week.
The mechanical part is right: commit, pinned, oid, size and lfs all move together, and nothing else in the pin file drifts. A bump that updates the oid without the size (or vice versa) is how a cache ends up serving the old bytes under a new pin; that did not happen here.
Scope note, in this PR's favour: the upstream commits are mostly Update README.md, which is why a reader could mistake this for a documentation bump. It is not, and the table's "different bytes" line is the evidence -- my only ask is that the sentence after it exists.
|
VERDICT: READY at The line that mattersThat is +100 MB under an identical filename. Two consequences, and neither is about this PR's diff:
Ask: this deserves its own paragraph, not a table row — "the UD-Q4_K_XL file was re-uploaded upstream; the new sha is And the bump is otherwise well-formed
Two asks
|
|
VERDICT: READY at 14:32 CHANGES -> 14:50 READY, same head: the re-review checks the table line by line and finds one held file re-added rather than moved. Posted on the owner's instruction: the gate refuses a PR whose older CHANGES at the same head was never withdrawn, even where the later READY at that head settles it. Nothing new is asserted here; this line exists so the gate can see what the thread already says. |
|
To pi-pkg (owner of |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY at f731f60 - withdraws my CHANGES of 14:32
Re-posted as a review: the CHANGES was a review object, and a withdrawal that lands as a comment leaves it standing for any reader (or gate) that counts reviews. Nothing new is asserted.
Bumps the pin of
unsloth/Qwen3.8-27B-GGUFfrom4ca72078to4af51b35(4af51b3542f775b0a8e4b310bfb3f17e01c306c9).Upstream commits since the pin:
4af51b352026-11-12 New UD3.1 UD-Q3_K_XLce331efc2026-11-11 Update README.mdf18d9d862026-11-11 Update README.mdda3e81b42026-11-11 Update README.mdacb953b12026-11-11 New UD3.1 quants43f522df2026-11-10 New UD3.1 quantsQwen3.8-27B-UD-Q4_K_XL.gguf3f227079003a…, upstream 17,659,407,264 B2a5f3565f39c…29 new file(s) appeared upstream:
BF16/Qwen3.8-27B-BF16-00001-of-00002.gguf,BF16/Qwen3.8-27B-BF16-00002-of-00002.gguf,Qwen3.8-27B-Q4_0.gguf,Qwen3.8-27B-Q4_1.gguf,Qwen3.8-27B-Q8_0.gguf,Qwen3.8-27B-UD-IQ1_M.gguf,Qwen3.8-27B-UD-IQ1_S.gguf,Qwen3.8-27B-UD-IQ2_S.ggufMerging the pin does not adopt the new revision anywhere: the catalog entry, the stick image and
the scoreboard each move on their own reviewed change. Merging says this is the revision we
point at — so the template column above has to be clean first (docs/model-pins.md).
Report:
tools/pin_watch.py --check(the dailypin-watchworkflow).