Skip to content

ggml-hrx: the forward declaration says bool, matching the definition, so the pin builds again (unbreaks GGML_HRX=ON) #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bong-water-water-bong merged 1 commit into from
Nov 9, 2026
Merged

ggml-hrx: the forward declaration says bool, matching the definition, so the pin builds again (unbreaks GGML_HRX=ON) #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ggml/src/ggml-hrx/ggml-hrx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,11 @@ static const ggml_backend_buffer_i buffer_i = {
// engine #1502 (#251) calls this from buffer_alloc, eight hundred lines above its definition, with no declaration in
// scope - so the translation unit does not compile ("'device_free_total' was not declared in this scope"). One forward
// declaration is enough; the definition and its callers are unchanged.
static void device_free_total(ggml_backend_hrx_device_context * device_ctx, size_t & free_bytes, size_t & total_bytes);
// The declaration must match the definition's type: it is `bool` (it reports whether the driver counters were
// available). Two merges each added a forward declaration - #252's above, #240's `bool` one further down - and the
// `void`/`bool` pair is an ambiguous redeclaration, so the translation unit fails to compile at the `bool` declaration
// and the pin builds for nobody. One word, and every lane that builds this pin is unblocked.
static bool device_free_total(ggml_backend_hrx_device_context * device_ctx, size_t & free_bytes, size_t & total_bytes);

static ggml_backend_buffer_t buffer_alloc(ggml_backend_buffer_type_t buft, size_t size) {
ggml::hrx::onebit::poison_selftest(); // no-op unless GGML_HRX_POISON_SELFTEST=1
Expand Down