Repository navigation
Conversation
lin-coco
marked this pull request as ready for review
October 30, 2026 05:20
Lithe Review结论: ⛔ 有阻塞 Findings
Scope Check
Suggestions
Summary共享 Core 与原生 Git 的复用合理,但 Windows 的根归属尚未贯穿库存和语言服务。Finding 1 应在合并前修复;其余为非阻塞建议。 Verification
|
feat(macos): 补齐全局编辑器样式与 VS Code/IDEA 语法配色
fix(search): 修复搜索布局并支持文件名优先展示与滚动自动分页
* feat(macos):完善类方法跳转与悬停导航交互 * fix(macos): 稳定慢查询期间的 Command 悬停光标 * fix(editor): present Java files after initial import folding * fix(editor): delay Command hover hints and cancel pending hints on leave * fix(editor): show Command navigation feedback before semantic lookup * fix(editor): exclude non-code tokens from Command navigation * fix(editor): color Java comment delimiters as comments * feat(macos): preserve navigation toggle implementation for integration * fix(macos): unify welcome actions and clone remote panels * feat(java-support): own optional class and method navigation lifecycle * fix(navigation): sync plugin opt-out across projects and preserve other providers * fix(i18n): preserve catalog ordering after preview merge * test: align Java generator host capabilities and pin Git fixture branch * fix(remote): resolve daemon startup before attaching concurrent clients * fix(windows): provide the optional Java requirements snapshot * feat(editor): 类方法跳转默认开启并新增 Java 关键字跳过查询设置 - 撤销插件级 classMethodNavigation / editorNavigation 开关(设置、策略表、校验和契约 fixture)。F12、Command 点击、悬停提示和 implementation 回退对所有语言默认生效,由宿主统一实现。 - 新增宿主设置“Java 关键字不查询定义”(设置 → 编辑器,默认开启):关键字位置不再发送定义查询,避免语言服务器对 static、switch 等关键字等待约 7 秒。 - Java 库类跳转优先读取本地 -sources.jar(~/.m2、~/.gradle 缓存),找不到时回退到 JDT LS 反编译。 - 删除已废弃的开关截图,新增关键字设置截图。 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> * fix(matrix): 移除已删除的 editor-navigation fixture 证据路径 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> * fix(navigation): 仅对 jar 内库类异步查找 sources jar 非 jar 的虚拟文档保持同步请求语言服务器,避免选择器接受目标后的源码请求被推迟; 合并 preview 并修复 Java 实现选择器相关回归测试。 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> * fix(navigation): 撤回 sources jar 快速路径并保留 this/super 构造器跳转 - 撤回本地 sources jar 快速路径:文本与 JDT 返回的坐标不一定对应,且 jar 文件名无法确认依赖身份,统一回到语言服务器虚拟文档。 - Java 关键字过滤不再包含 this 和 super,它们对应构造器调用,仍会发送定义查询。 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> * test(macos): align rollback symlink assertion with document errors * test(git): 为子模块测试的 git submodule add 放宽超时 Windows runner 上 git submodule add 克隆子模块超过辅助函数写死的 10 秒, 进程被取消,导致 watch_context_resolves_a_submodule_git_directory_outside_its_workspace 失败。该测试的时间预算已在 test-stability-windows.ps1 中放宽到 30 秒, 这里把命令超时与预算保持一致,其余 git 命令仍使用 10 秒。 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Haiku 5.5 <noreply@anthropic.com> Co-authored-by: lick <2188718831@qq.com>
…97-review-windows-ci
Fix attached-root LSP gates and reevaluate documents when workspace roots change. Carry request-local ownership through inventory, search, replacement and incremental index caches; preserve scoped search when unrelated roots are unavailable. Disable unsupported remote indexing settings, localize settings failures, normalize both Java exclusion test expectations, and register regressions in Windows CI.
lin-coco
marked this pull request as draft
October 30, 2026 08:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git 忽略或手动排除的目录此前仍会进入搜索库存;本次由共享 Core 统一执行索引排除,并将项目级开关统一到两端“设置 › 版本控制 › Git”。排除目录仍可浏览,文件仍可直接打开编辑。
Closes #958
功能与修复
check-ignore与ls-files判断目录排除并保护已跟踪内容;支持项目包含例外、手动父目录优先、策略版本失效和关闭后的迟到工作拒绝。不改写.gitignore、Git 配置或项目构建配置;单个被忽略文件不会升级为目录排除。/,保留目录自身、后代及所有配置通道的完整断言。workspaceRoots,省略时保持单根兼容。父根剪枝另行登记的嵌套根,由该根按自身策略扫描;边界进入缓存身份并用于保存/watcher 直更。移除嵌套根恢复父根扫描,失效的无关根不阻断有效根的限定搜索,缺失后代保留边界。根成员来自本次请求,避免其他窗口或退役策略改变结果;旧根集合的迟到结果不能发布。macOS 界面截图
以下五张截图采集于提交
7563ec71的 macOS 原生验收,使用独立Exclusion-Demo项目及测试 Git 身份,覆盖 Git 设置入口、说明提示和目录菜单。Windows 原生界面截图仍待补充。1. Git 设置入口与统一开关
通过
exclude搜索定位到“版本控制 → Git”。自动排除位于 Git 程序与凭据区域之后,使用与“使用凭据助手”一致的小型 switch;截图中的 Git 姓名和邮箱均为测试值。2. 项目作用范围与语言服务限制
ⓘ 提示说明:开关只作用于当前项目,不受 Git 的全局/仓库配置范围影响;取消排除保存项目例外,不修改 Git 忽略规则。提示也保留 Java、Rust、Go 和 Python 等语言服务的实际支持边界。
3. 普通目录保留六种标记
ordinary未被排除,可选择普通、源码、资源、排除、模块和包六种角色。4. Git 自动排除目录仅显示取消排除
示例
.gitignore包含ignored/。该目录仍显示在项目树中,标记子菜单只有“取消排除”,不会同时显示源码、资源等其他角色。取消后使用项目包含例外,不改写.gitignore。5. 子目录继承父目录的手动排除
manual-parent已手动排除,child继承排除,菜单也仅显示“取消排除”。需要恢复该子目录时,须先取消父目录排除,子目录的包含例外不能绕过手动父目录。本地验证
preview的f3ee7114,本轮修复提交为ba421e25。7563ec71。Windows CI
当前提交
ba421e25的 Windows CI #41017649380 全部成功。已下载并复核 Windows Rust 报告:2,043 项通过、42 项跳过、0 项失败。此前失败的 Java 配置往返断言和另一处路径断言均实际执行通过(49 ms / 27 ms);嵌套根扫描与失效根回归通过。真实 JDT 车道也执行通过这两处断言。Windows 前端日志确认根增删关闭/恢复工作副本、最近根门禁、旧根集合结果拒绝和损坏设置分类回归均通过。以上自动化结果不代替原生界面截图与手动交互验收。
范围与验证限制
cargo check仍遇到project_window_registry.rs的 Windows 专有 API 报错(E0433 / E0599),未观察到新增字段或签名错误。