Repository navigation
fix(macos): #1599 恢复系统重开的设置窗口内容 - #1601
Merged
xiaoyumuxi merged 1 commit intoOct 30, 2026
Merged
Conversation
lin-coco
marked this pull request as ready for review
October 30, 2026 08:07
Lithe Review结论: 未发现需要阻塞合并的问题。未发现满足证据要求的新增代码缺陷。 Scope Check
Suggestions
Summary绑定准备与释放的职责清晰,令牌检查覆盖了同一会话重新打开时的旧回调风险。新增测试包含真实宿主挂载、深浅外观、有界等待及清理路径;静态审查未发现明确回归。 Verification
|
Collaborator
|
好的好的,这个问题我电脑上没有遇到过,我看看 |
xiaoyumuxi
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1599
macOS 恢复之前打开的设置窗口时,没有经过显式设置命令建立会话绑定,导致窗口持续空白。本次在设置宿主出现时补齐绑定,保留系统窗口恢复。
改动
验证
settings;修复后 3/3 恢复出完整设置,系统日志逐轮确认恢复标识。应用重开验收涵盖欢迎页、项目上下文、深浅外观、搜索、取消/确认/标题栏关闭和再次打开。没有执行额外的整机重启。.artifacts/test-stability/settings-restoration-final.{json,html,junit.xml}。验证限制
本机为 macOS 27.2 / Xcode 27.1 / Swift 6.4,与仓库固定 Swift 6.3.3 不同。完整 macOS 测试记录 3802 项,其中 3801 项通过,唯一失败是未修改的
PluginUIIconTests.commandPaletteUsesSelectedTintAndPreservesBrands:4 个参数组合共 8 条禁用行鼠标点击断言失败。使用未修改的 preview 基线f3ee7114ff713e9ddd2659c6cd6db353abef3138重新编译并执行同一测试,也得到完全相同的 8 条失败;对照后已逐字节恢复修复源码。本 PR 保留该测试,未放宽断言或跳过检查。完整测试报告:
.artifacts/test-stability/settings-restoration-full.{json,html,junit.xml};基线对照:.artifacts/test-stability/preview-baseline-icon.{json,html,junit.xml}。固定工具链和其他平台结果以本 PR CI 为准。