Skip to content

feat: add automatic multi-platoon management - #39

Merged
1window2 merged 4 commits into
mainfrom
beta
Aug 25, 2026
Merged

feat: add automatic multi-platoon management#39
1window2 merged 4 commits into
mainfrom
beta

Conversation

@1window2

Copy link
Copy Markdown
Owner

Summary

  • isolate management databases, retained CSV evidence, checkpoints, cutlines, ordering, timezone, and one-time-capture state by Android client, selected server region, and authoritative Platoon ID
  • quarantine decoded flow data until Android flow ownership and a valid 21905 Platoon identity agree, while preserving v2.3.x data as an unmoved legacy profile
  • add profile selectors across Home, Platoon, Weekly, and Settings plus profile-aware format-v3 backup and restore
  • resolve all six inherited Codex review findings from PR feat: release GF2logger v2.3.3 #38 and harden restore, activity recreation, profile bounds, metadata validation, and capture cleanup
  • update the architecture, security model, English/Korean documentation, and v2.4.0 changelog

Verification

  • testDebugUnitTest
  • lintDebug assembleDebug
  • lintRelease assembleRelease
  • 52/52 instrumentation tests on Samsung SM-N976N (Android 12)
  • signed release APK verified with Android apksigner; certificate matches the pinned permanent release fingerprint
  • non-destructive physical-device update from v2.3.3 to v2.4.0 preserved onboarding completion, Korean/dark settings, packet history, the legacy weekly table, and 14 active / 49 withdrawn members
  • live HaoPlay and Darkwinter captures created separate client/region/Platoon profiles, databases, retained CSV roots, and selectors without cross-profile checklist completion

Copilot AI lite review requested due to automatic review settings August 24, 2026 14:10

This comment was marked as outdated.

@1window2

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Security Review

Here are some automated security review suggestions for this pull request.

Reviewed commit: 7a95e2b503

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Comment thread app/src/main/java/dev/gf2log/app/capture/CaptureVpnService.kt

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a95e2b503

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/src/main/java/dev/gf2log/app/management/PlatoonBackupManager.kt Outdated
Comment thread app/src/main/java/dev/gf2log/app/capture/CaptureVpnService.kt
Comment thread app/src/main/java/dev/gf2log/app/management/PlatoonRepository.kt Outdated
Comment thread app/src/main/java/dev/gf2log/app/capture/CaptureVpnService.kt Outdated
Comment thread app/src/main/java/dev/gf2log/app/management/MembershipConsistencyPolicy.kt Outdated
Comment thread app/src/main/java/dev/gf2log/app/PlatoonProfileSelector.kt
@1window2 1window2 self-assigned this Aug 24, 2026
@1window2 1window2 added the enhancement New feature or request label Aug 24, 2026
@1window2

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 7d2a17ce0f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@1window2

Copy link
Copy Markdown
Owner Author

Resolved the Codex Security finding “Flow metadata leaks for non-parsed VPN connections” in 259e083 (with the original unconditional no-parser cleanup already present since 7a95e2b).

The close path now removes parser and metadata state independently, including queue rejection, and delayed open work cannot republish metadata for a quarantined flow. Focused regression tests cover no-parser cleanup, paired parser/metadata cleanup, rejected-close/open ordering, and normal registration. Full unit tests, debug/release lint, signed release assembly, production-certificate verification, and an in-place physical-device update all passed.

Repository owner deleted a comment from chatgpt-codex-connector Bot Aug 25, 2026
@1window2
1window2 merged commit 318dd81 into main Aug 25, 2026
5 checks passed
@1window2

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@1window2 1window2 added the design codes that affect frontend design label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design codes that affect frontend design enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants