Record Volcengine replay smoke readiness - #90
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc082c7231
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - credential 优先读取 `VOLCENGINE_API_KEY`,兼容 `ARK_API_KEY`; | ||
| - `model_name` 必须是精确 Model ID 或 Endpoint ID; | ||
| - `/api/plan/v3` 与 `/api/coding/v3` 在代码、测试和文档中明确拒绝; | ||
| - `smoke` 默认只运行 `clean_requests_session`,验证 credential、endpoint、JSON object、usage 和 artifact; |
There was a problem hiding this comment.
Do not claim smoke validates JSON and usage
When Ark returns malformed JSON or omits token usage, parse_provider_answer() records a parse_error fallback and run_provider_answer_replay() still reports status="completed"; incomplete usage is likewise represented only by usage.complete=false. The smoke workflow checks neither field before succeeding, so a green smoke can currently fail both guarantees documented here and still unlock the full runs described below. Either enforce parse_error == "" and complete usage in the smoke validation or describe these as manual inspection items rather than validated contract properties.
Useful? React with 👍 / 👎.
| PR #89 建立以下边界: | ||
|
|
||
| - `VolcengineArkReplayProvider` 继承 provenance-approved real-provider replay adapter; | ||
| - 仅使用标准方舟 OpenAI-compatible `/api/v3`; |
There was a problem hiding this comment.
Describe the Ark endpoint as a default, not a restriction
When an operator supplies the workflow's optional base_url, VolcengineArkReplayProvider._validated_base_url() accepts any single-line URL except the two explicitly forbidden path substrings; it does not require the Ark host or /api/v3. Such a run is still labeled with provider_profile="volcengine", so the statement that this adapter uses only the standard endpoint overstates the recorded provenance boundary. Either enforce the claimed endpoint restriction or say that /api/v3 is merely the default.
Useful? React with 👍 / 👎.
Scope
Synchronize the single project-status source after PR #89 merged.
Recorded facts
mainb1fac061f390cf224fe9288e7786474c3d1d1f6e898cb0599e941830dd16e48185584719acceb7da/api/v3, exact Model/Endpoint ID andVOLCENGINE_API_KEYwithARK_API_KEYfallback are recordedValidation
Documentation-only synchronization. Keep Draft until the complete repository CI passes.