Skip to content

Record Volcengine replay smoke readiness - #90

Merged
2002yy merged 1 commit into
mainfrom
docs/p0-e3-volcengine-status
Jul 29, 2026
Merged

Record Volcengine replay smoke readiness#90
2002yy merged 1 commit into
mainfrom
docs/p0-e3-volcengine-status

Conversation

@2002yy

@2002yy 2002yy commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Scope

Synchronize the single project-status source after PR #89 merged.

Recorded facts

  • replay-only Volcengine Ark adapter and bounded smoke/full workflow are in main
  • PR Add Volcengine smoke and full Provider replay #89 merge SHA b1fac061f390cf224fe9288e7786474c3d1d1f6e
  • final feature head 898cb0599e941830dd16e48185584719acceb7da
  • CI #1696 passed all backend, RAG, static, security, mypy, frontend, browser and real-stack gates
  • standard Ark /api/v3, exact Model/Endpoint ID and VOLCENGINE_API_KEY with ARK_API_KEY fallback are recorded
  • Agent Plan and Coding Plan endpoints are explicitly rejected
  • smoke runs one fixed answerable case; full runs all 10 cases plus offline AnswerClaim evaluation
  • no real smoke or full run exists yet, so no real model-quality metric is claimed
  • next operation is manual Volcengine smoke; only a green smoke unlocks two full runs
  • production Volcengine chat Provider, claims, ChatTurn writes and executable-agent expansion remain frozen

Validation

Documentation-only synchronization. Keep Draft until the complete repository CI passes.

@2002yy
2002yy marked this pull request as ready for review July 29, 2026 12:48
@2002yy
2002yy merged commit 400613b into main Jul 29, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc082c7231

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/PROJECT_STATUS.md
- credential 优先读取 `VOLCENGINE_API_KEY`,兼容 `ARK_API_KEY`;
- `model_name` 必须是精确 Model ID 或 Endpoint ID;
- `/api/plan/v3` 与 `/api/coding/v3` 在代码、测试和文档中明确拒绝;
- `smoke` 默认只运行 `clean_requests_session`,验证 credential、endpoint、JSON object、usage 和 artifact;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not claim smoke validates JSON and usage

When Ark returns malformed JSON or omits token usage, parse_provider_answer() records a parse_error fallback and run_provider_answer_replay() still reports status="completed"; incomplete usage is likewise represented only by usage.complete=false. The smoke workflow checks neither field before succeeding, so a green smoke can currently fail both guarantees documented here and still unlock the full runs described below. Either enforce parse_error == "" and complete usage in the smoke validation or describe these as manual inspection items rather than validated contract properties.

Useful? React with 👍 / 👎.

Comment thread docs/PROJECT_STATUS.md
PR #89 建立以下边界:

- `VolcengineArkReplayProvider` 继承 provenance-approved real-provider replay adapter;
- 仅使用标准方舟 OpenAI-compatible `/api/v3`;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Describe the Ark endpoint as a default, not a restriction

When an operator supplies the workflow's optional base_url, VolcengineArkReplayProvider._validated_base_url() accepts any single-line URL except the two explicitly forbidden path substrings; it does not require the Ark host or /api/v3. Such a run is still labeled with provider_profile="volcengine", so the statement that this adapter uses only the standard endpoint overstates the recorded provenance boundary. Either enforce the claimed endpoint restriction or say that /api/v3 is merely the default.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant