fix(chain): Assume CF header is checked when in header only - #608
Merged
Merged
Conversation
Headers-only sync caused a condition where, if more than 1 peer is used to sync, the CF headers would not have a commitment when doing a handshake with the second peer, causing the node to download all the CF headers from the checkpoint. Whenever `assume_checked_to` is called, the filter headers are also marked as checked here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Headers-only sync caused a condition where, if more than 1 peer is used to sync, the CF headers would not have a commitment when doing a handshake with the second peer, causing the node to download all the CF headers from the checkpoint. Whenever
assume_checked_tois called, the filter headers are also marked as checked here.