Fixed wrong link for webui build instructions in README - #75
Conversation
Previous link was just the diff of some random commit about date handling? I'm assuming this is a mistaken paste, changed it to a more appropriate link.
|
No, the link was a specific commit which has been tested on. The main branch may have a broken code at any given moment. CI build also refers a specific commit rather than main branch (missed the mismatch with docs). It all should be updated probably to https://github.com/ActivityWatch/aw-webui/tree/464405d33d1b29d86b9e7c4a0bee708951f24b46 which is indirectly referred by the latest release https://github.com/ActivityWatch/activitywatch/tree/v0.14.0b3 |
|
Oh, well should i edit the PR to change it to that link? In truth the relevant section is the #building section, which just includes two commands, EDIT: Wait, if the build requires a specific version of webui anyway, then why not add it as a git submodule? Since you don't have any other submodules, the build instructions would become as simple as running |
It would be nice if you do, yes, https://github.com/ActivityWatch/aw-webui/tree/464405d33d1b29d86b9e7c4a0bee708951f24b46#building would be appropriate.
That's a reasonable idea, technically, and I thought about it initially. This concerns only the bundle, I wasn't sure how to position the app, submodules aren't very widespread, and if I'm not going to split into a separate repo, and made the more conservative choice. Possibly, I might review that decision. |
Previous link was just the diff of some random commit about date handling? I'm assuming it was just a mistaken paste. Changed it to a more appropriate link.