Skip to content

Missmatch in ts_Aretomo.patch #28

Description

@danielmarchan3

if patches := subargs.pop('--patches', None):

In form emw-warp-tsalign.json the
{
"name": "ts_aretomo.patches",
"label": "Patches",
"help": "Number of patches for local alignments in X, Y, separated by 'x': e.g. 6x4. By default (empty, or 0x0 or 1x1) only global alignment is performed. More patches increase the processing time."
}

Is expecting this parameter as XxY e.g. 4x4. However, for warp aretomo2 this implementation is correct but for warp aretomo3 it is expecting 4,4. We should make this parameter intelligent enough to accept different kind of string and then converting back depending on which alignment you are calling afterwards. For instance accepting: "4x4", "4 x 4","4 4", "4, 4", "4,4".

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't working

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions