This repository was archived by the owner on Mar 31, 2025. It is now read-only.
Fixes crash when URL points to a domain without PTR record - #3
Open
ph5i wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that if the URL provided points to a domain without a PTR record, the
gethostbyaddr()function will fail because a reverse DNS lookup can't be performed, ultimately causing the script to crash since exceptions are not handled gracefully.I added basic error handling in
get_RealAddress.pyto return "Not found!" if no PTR record exists and updatedget_AppDefinitions.pyslightly for cleaner output.