Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

swapOwner can fail in CPKFactory #132

Description

@hexyls

If the estimated gas for createProxyAndExecTransaction is too low swapOwner can fail silently during execTransaction to Gnosis Safe v1.2.0 while not rolling back the whole transaction.

Users can potentially lose funds if they transfer assets to the proxy and ownership of the proxy is not successfully assigned to the user.

Transfer of ownership is not verified after the swapOwner call. We should probably check the return value of execTransaction to check if the transaction was successful.

example transaction

Should be considered for #126

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions