Skip to content

Stabilize randomized bot tests #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
8tp merged 1 commit into from
Aug 8, 2026
Merged

Stabilize randomized bot tests #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/server/BotController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,11 +312,14 @@ export class BotController {
const delay = BOT_EMOTE_DELAY_MIN + Math.random() * (BOT_EMOTE_DELAY_MAX - BOT_EMOTE_DELAY_MIN);
const botId = bot.id;
const botName = bot.name;
bot.lastEmoteTime = now;

this.pendingEmoteTimeout = setTimeout(() => {
if (this.destroyed) return;
this.pendingEmoteTimeout = null;
// Cooldown is defined between audible/visible emotes, not between the
// times they were scheduled. Random delivery delays can differ, so
// recording `now` above could let two emitted reactions land closer
// together than BOT_EMOTE_COOLDOWN_MS.
bot.lastEmoteTime = Date.now();
this.onBotEmote?.(botId, botName, reactionId);
}, delay);

Expand Down
2 changes: 2 additions & 0 deletions tests/engine/BotBrain.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,6 +987,7 @@ describe('BotBrain', () => {
let aggChallenges = 0;
let conChallenges = 0;
const trials = 500;
const randomSpy = vi.spyOn(Math, 'random').mockImplementation(seededRandom(0xC0A9));

for (let i = 0; i < trials; i++) {
const aggResult = decide(game, 'p2', BOT_PERSONALITIES.aggressive, {
Expand All @@ -999,6 +1000,7 @@ describe('BotBrain', () => {
});
if (conResult?.type === 'challenge') conChallenges++;
}
randomSpy.mockRestore();

// Aggressive should challenge more than conservative
expect(aggChallenges).toBeGreaterThan(conChallenges);
Expand Down