feat(qemu): Feature for enabling virtfs - #3829
Conversation
error: features "usermode" and "systemmode" cannot be used together
--> crates/libafl_qemu/libafl_qemu_sys/build_linux.rs:11:13
|
11 | compile_error!(concat!("features \"", $first, "\" and \"", $rest, "\" cannot be used together"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
27 | assert_unique_feature!("usermode", "systemmode");
| ------------------------------------------------ in this macro invocation
|
= note: this error originates in the macro `assert_unique_featureprobably happens because some --all-features thing enables usermode while you enable systemmode here... @rmalmain maybe it would be a good idea to have usermode as default and systemmode as feature - that way we have one less exclusive feature flag? |
--> crates/libafl_qemu/libafl_qemu_sys/build_linux.rs:11:13
|
11 | compile_error!(concat!("features \"", $first, "\" and \"", $rest, "\" cannot be used together"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
27 | assert_unique_feature!("usermode", "systemmode");
| ------------------------------------------------ in this macro invocation
|
= note: this error origis this part of our CI or due to this PR? |
|
Looked into the CI failure I don't think it's caused by this PR. virtfs declares systemmode the same way slirp and intel_pt already do, so an --all-features-style job should already be hitting the same usermode/systemmode conflict on those. This looks like a pre-existing gap in the feature-exclusion list for that job, not something new here virtfs just needs to be added wherever slirp/intel_pt are already excluded. Confirmed in isolation this builds fine: Separately: the OpenSSL precommit failure looks like a local toolchain issue, unrelated to this diff. |
Description
Fixes #3824.
Checklist
./scripts/precommit.shand addressed all comments^ this failed for me with a message about openssl