fix(chat): implement a real MCP client in McpToolConverter - #387
Open
robbee wants to merge 1 commit into
Open
Conversation
The chat assistant's "MCP provider" tool integration posted a raw
{"input": "..."} body to the configured server instead of speaking
the MCP JSON-RPC protocol, so it failed against any spec-compliant
MCP server (including OpenDeepWiki's own /api/mcp) with
"406 Not Acceptable: Client must accept both application/json and
text/event-stream".
Replace it with the official ModelContextProtocol.Client SDK:
connect over Streamable HTTP, list the server's real tools, and
expose each one individually to the agent (via McpClientTool, which
is itself an AIFunction) instead of one opaque wrapper tool. Bump
the ModelContextProtocol package to 1.3.0 to match
ModelContextProtocol.AspNetCore and resolve a NU1605 downgrade
error.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Admin > Tools > MCPs→EnabledMcpIds) sent a raw{"input": "..."}POST instead of speaking the MCP JSON-RPC protocol, so it failed against any spec-compliant MCP server — including OpenDeepWiki's own/api/mcp— with406 Not Acceptable: Client must accept both application/json and text/event-stream.ModelContextProtocol.ClientSDK: it now connects over Streamable HTTP, performs the real handshake, and exposes each tool the server advertises individually to the agent (viaMcpClientTool, which is itself anAIFunction) instead of one opaque wrapper tool.ModelContextProtocolpackage to1.3.0inDirectory.Packages.propsto matchModelContextProtocol.AspNetCoreand resolve aNU1605downgrade error that surfaced once the client package was referenced directly.Test plan
docker compose build opendeepwikisucceeds with 0 errorshttp://localhost:8080/api/mcp) and enabled it on the Chat AssistantLoaded N tools from MCP serverreplaces the oldNot Acceptablefailure🤖 Generated with Claude Code