[Bug]: LC0019 code action not needed?

[NKarolak]

Analyzer

LinterCop

Issue type

Other

Rule ID

LC0019

Description

ALCops offers a code action that is already provided by the AL Langauge. Here you can see both:

If the ALCops code action works different than the standard one, or if there is another good reason to keep them both, then that should be documented.

AL code to reproduce

No response

Additional context

No response

[Arthurvdv]

Hi @NKarolak, thanks for the detailed report and the screenshot!

Could it be possible that you have BusinessCentral.LinterCop active side-by-side with ALCops?

Looking closely at the screenshot, both entries are actually code fixes for the same diagnostic, LC0019 — they each offer "fix all LC0019":

• ALCops: Remove redundant DataClassification is the code fix from ALCops (this project).
• Remove DataClassification matches the code fix from the original BusinessCentral.LinterCop, whose LC0019 action is titled exactly "Remove DataClassification".

Two providers can only show up together like that when both analyzer assemblies are loaded into the same compilation — so it looks like both ALCops and the original LinterCop are active at the same time. That would also explain the duplicate: ALCops is a continuation of BusinessCentral.LinterCop and keeps the same LC rule IDs, so both implement LC0019 identically. It isn't from the AL Language / Microsoft.

If that's the case, running both side-by-side isn't a supported setup — you'd see doubled diagnostics and code actions across many LC#### rules, not just this one. Enabling only one of the two (e.g. removing BusinessCentral.LinterCop from your analyzer configuration if you're moving to ALCops) should make the duplicate Remove DataClassification action disappear.

Could you check your analyzer configuration and let us know? That'll confirm whether this is the side-by-side scenario or something we need to dig into further.

[NKarolak]

The LinterCop extension is not installed anymore. Maybe some remains are still lurking around ...?

My workspace settings file does not contain the old LinterCop, and there is no local setting overriding it:

    "al.codeAnalyzers": [
      "${AppSourceCop}",
      "${CodeCop}",
      "${UICop}",
      "${analyzerFolder}ALCops.FormattingCop.dll",
      "${analyzerFolder}ALCops.LinterCop.dll",
      "${analyzerFolder}ALCops.PlatformCop.dll",
      "${analyzerFolder}ALCops.TestAutomationCop.dll",
      "${analyzerFolder}ALCops.Common.dll"
    ]

[Arthurvdv]

To be very honest, I have no clue what is causing this 🤔

The only thing I can think of that we can check is the C:\Users\<username>\.vscode\extensions\ms-dynamics-smb.al-<version>\bin\Analyzers folder and check whether there is still a BusinessCentral.LinterCop.dll file there. If it is, then try deleting it and see if that makes any difference.

What I find strange is that LinterCop isn't configured in your workspace settings.json, so I'm not really sure why it would still be loaded/provide the code action in the first place.