Release/v1.3.1 - #552
Merged
Merged
Release/v1.3.1#552
Conversation
#542) DisposeAsync cancelled the shutdown token and stopped the TcpListener before the serve loop had observed the cancellation. When the loop reached AcceptTcpClientAsync after Stop(), .NET threw InvalidOperationException ("Not listening") instead of an OperationCanceledException, failing the last test that used the server. Cancel, await the loop, then stop the listener. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…d receiver (#551) IInvocationExpression.Instance is null for static built-in class calls (IsolatedStorage.Get, NumberSequence.Next, bare Error) as well as for bare implicit-self calls inside tables and tableextensions. GetReceiverTableType treated every null instance as bare self and resolved IsolatedStorage.Get inside a table to the enclosing table, so PC0013 compared the call's arguments with the primary key. GetReceiverTableType now takes the invocation or field access itself instead of its Instance and returns no table when a null-instance invocation targets a static method: IMethodSymbol.IsStatic on net8.0/net10.0, and on netstandard2.1 (AL 12 has no IsStatic) a TargetMethod.ContainingSymbol that is an IClassTypeSymbol other than Table. All eleven callers across ApplicationCop, DocumentationCop, LinterCop, PlatformCop and the permissions detector share the fix. Regression fixtures cover IsolatedStorage.Get inside a table procedure, a table trigger and a tableextension. The receiver-forms guide, the netstandard2.1 compatibility table and the fix-false-positive regression catalog record the null-instance ambiguity. Fixes #550 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # .claude/rules/netstandard21-compatibility.md # .claude/rules/record-receiver-forms.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.