fix(common): route net10.0 through reflection for SDK-volatile APIs - #553
Merged
Merged
Conversation
The CI net10.0 SDK changed QuoteIdentifierIfNeeded from 2 to 3 params and removed six AnalysisView enum members. Shift the direct-call guard to NET11_0_OR_GREATER and update the #if guards on AnalysisView entries in EnumProvider from NETSTANDARD2_1 || NET8_0 to !NET11_0_OR_GREATER, keeping compile-time nameof() validation for future TFMs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The method went from 1-param to 2-param in AL v16+; there is no 3-parameter version. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QuoteIdentifierIfNeededdirect-call guard fromNET10_0_OR_GREATERtoNET11_0_OR_GREATERso net10.0 routes throughStringHelperreflection (the SDK method went from 1-param to 2-param in AL v16+, and net10.0 can now load either version)#if NETSTANDARD2_1 || NET8_0to#if !NET11_0_OR_GREATERfor six AnalysisView entries inEnumProvider(SymbolKind.AnalysisView,SyntaxKind.PageAnalysisView,PageAnalysisViewList,PageExtensionAnalysisViewList,AnalysisViewAddChange,AnalysisViewModifyChange) — these enum members don't exist in the current net10.0 SDKStringExtensions.csandStringHelper.csto include net10.0Fixes the 7 compile errors from scheduled CI run 35335185225.
Test plan
🤖 Generated with Claude Code