docs: explain LockTable in table triggers and the convert-or-delete choice for LC0031 - #185
Merged
Merged
Conversation
…hoice for LC0031 Rewrite the LC0031 page with the mechanism-first voice: why LockTable is transaction-wide, what ReadIsolation changes, and how tri-state locking falls back. Add Convert or delete (BCQuality criterion), LockTable in table triggers (the reporter's question), and Code fix sections. Add Microsoft Learn blockquotes and BCQuality/Mads Gram references. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Merged
9 tasks
…mple pairs Point the BCQuality references at the microsoft/BCQuality knowledge folder, give both trigger shapes a bad and a fixed example with the standard diagnostic comment, and fix the highlighted lines. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Arthurvdv
added a commit
to ALCops/Analyzers
that referenced
this pull request
Sep 13, 2026
…eiver forms (#547) Issue #530 reported LC0031 firing on bare LockTable() inside Base App table triggers and a code action that changed nothing there. The trigger case is reported on purpose: the compiler binds every receiver form to the same built-in, LockTable is transaction-wide while ReadIsolation is instance-local, and Microsoft's own new code no longer writes LockTable in triggers. The defect was the code fix, which returned the unchanged document whenever the invocation had no member-access receiver. - Code fix: a bare LockTable() becomes a bare ReadIsolation(IsolationLevel::UpdLock); member-access receivers keep their form; the replacement copies the trivia of the original call so indentation and comments survive. - Fixtures: the full receiver-form set (named variable, Rec, bare, this, tableextension, page, TableNo OnRun, namespaced, RecordRef, arguments), both ReadIsolation forms as NoDiagnostic, and a leading-comment HasFix case; tableextension fixtures gated on SDK 13.0, this fixtures on runtime 14.0. - Rule doc lc0031-record-instance-isolation-level.md records the trigger decision, the per-form verdicts and the SDK facts; the receiver-forms regression row now covers the code fix flavour of the gap. Closes #530 Related: #545 Docs: ALCops/alcops.dev#185, ALCops/alcops.dev#186 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LockTable()callRelated: ALCops/Analyzers#530
🤖 Generated with Claude Code