Fix GCC optimization guards for Clang - #241
Merged
mansnils merged 3 commits intoSep 22, 2026
Merged
Conversation
Contributor
Author
|
Hi! Just checking in on this PR. It looks like the workflows are still awaiting maintainer approval. Please let me know if there’s anything I should update or provide from my side. Thanks! |
Contributor
|
Thank you @ricardoasouz ! |
Contributor
|
Thanks for the PR. Could you update date and versions in the updated files? |
Signed-off-by: Ricardo Alves de Souza <ricardoasouz@hotmail.com>
ricardoasouz
force-pushed
the
fix/clang-gcc-optimization-guards
branch
from
September 22, 2026 11:13
6815908 to
bab91d6
Compare
Contributor
Author
Updated the date and minor versions in all three modified source files, and rebased onto the latest main. Thanks! |
mansnils
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #205
Clang defines
__GNUC__for GCC compatibility, but it does not support the GCC-specificoptimizeattribute and#pragma GCC optimizeused in these code paths.This change excludes Clang from the GCC-only optimization hints and also adds the missing IAR guard for
arm_depthwise_conv_s8.c.Validation:
optimizeattribute and#pragma GCC optimize.