Repository navigation
LambertW over the reals is defined where its branch is real - #2263
Merged
Merged
Conversation
lambertw's condition was the complex one under either reading: every whole branch, and every z but 0 off the principal one. So DomainConditionIn(Domain.Real) of lambertw(0, x) was True, though W_0(-1) is -0.318 + 1.337i. Over the reals the condition is now where the branch is real: W_0 for z >= -1/e, W_(-1) for -1/e <= z < 0, both -1 at -1/e, and no other branch anywhere. The complex condition is unchanged. LambertWOverTheRealsTest takes three branches at twelve real points over the reals, and three over the complex numbers; five fail on master. lambertw is new since 2.6.0, so no answer changes against it. Found by work/domaincheck. Part of #2256. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2263 +/- ##
==========================================
+ Coverage 86.69% 86.71% +0.02%
==========================================
Files 310 310
Lines 67830 67833 +3
Branches 19683 19684 +1
==========================================
+ Hits 58802 58821 +19
+ Misses 4910 4894 -16
Partials 4118 4118
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lambertw's condition was the complex one under either reading, soDomainConditionIn(Domain.Real)oflambertw(0, x)wasTrue, thoughW_0(-1)is-0.318 + 1.337i. Over the reals the condition is now where the branch is real:W_0forz >= -1/e,W_(-1)for-1/e <= z < 0(both are-1at-1/e), and no other branch anywhere. The complex condition is unchanged.LambertWOverTheRealsTest: five cases fail on master, and ten pass on both.lambertwis new since 2.6.0, so no answer changes against it and there is no BREAKING entry. Suite 18226 passed. The F# wrapper suite, the Mcp, Terminal and InteractiveWrapper suites and the AOT smoke test pass. BoundCheck, RootCheck, CasBench, PropCheck, SimpSweep, RuleCheck, CanonCheck and Confluence are unchanged. Found bywork/domaincheck.Part of #2256.
🤖 Generated with Claude Code