Repository navigation
-mm=own: a marker naming a parameter by an identifier is an error, not a crash - #755
Merged
Merged
Conversation
…t a crash `@keeps(it)` crashed MLIRGen: iterateDecorators evaluates an argument that is not a literal, an unresolved identifier evaluates to no type, and the dyn_cast of that null type faulted. The cast now takes a missing type, and processOwnParamMarkers reports an argument of @keeps, @borrows, @Lends or @immortalizes that is not a string literal at the argument: "'@keeps' takes the names of parameters as strings: '@keeps("it")'". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@keeps(it)(an unquoted parameter name) crashed MLIRGen with an access violation.iterateDecoratorsevaluates a decorator argument that is not a literal; an identifier that names nothing in scope evaluates to no type, anddyn_cast<LiteralType>of that null type faulted.iterateDecorators:dyn_cast_if_present, so an unreadable argument is skipped instead of crashing.processOwnParamMarkers: an argument of@keeps,@borrows,@lendsor@immortalizesthat is not a string literal is reported at the argument:'@keeps' takes the names of parameters as strings: '@keeps("it")'(@borrows(this)suggests'@borrows("this")'). Without it the dropped argument would have left the marker naming nothing.Test:
own/own_err_marker_identifier_arg(error test). Full release ctest: 6447/6447 passed (this worktree's build has no gtest, so the unit tests were not built).🤖 Generated with Claude Code