Skip to content

An asserted reference (<Reference<i32>>ref) reinterprets again (release blocker from #775) - #776

Merged
ASDAlexander77 merged 1 commit into
mainfrom
ref-assertion-reinterpret
Nov 6, 2026
Merged

ASDAlexander77 merged 1 commit into
mainfrom
ref-assertion-reinterpret

Conversation

@ASDAlexander77

Copy link
Copy Markdown
Owner

Release blocker for v0.0-pre-alpha116, found by the pre-release default-library check (debug + release default library built the way create-release.yml builds it, then tests.ps1 for every model).

#775 made a reference to a number cast to a reference to a number laid out otherwise an error (TSLANG 26). The check sat in cast(), which explicit assertions reach too. The default library's HashHelpers.hashCodeGeneral reads a number key's bits through <Reference<i32>>Ref(key), so every Map/Set with number keys stopped compiling. map_get_number, map_negative_keys and map_size_delete failed under gc, rc, none and own.

An assertion between two reference types (<Reference<i32>>ref, ref as Reference<i32>) is again a plain reinterpreting cast, as before #775. The layout check stays for implicit conversions: a call's argument (the TSLANG 26 case) or an assignment.

Tests

  • 00tslang_issues_24_26: reads 1.5's halves through <Reference<i32>> and as Reference<i32>; ref_element_layout_error still errors.
  • DefaultLib tests.ps1 (DL main 46113d8): gc 187/187; rc, none and own 186/187 plus the gc-only weakref skip. Release and debug, compile and jit.
  • Full ctest -C Release: 6670 tests, all passing.

🤖 Generated with Claude Code

…interprets again

#775 made a reference to a number cast to one laid out otherwise an error, in cast(), which
explicit assertions reach too. The default library's HashHelpers.hashCodeGeneral reads a
number key's bits through `<Reference<i32>>Ref(key)`, so every Map/Set with number keys failed
to compile (map_get_number, map_negative_keys, map_size_delete under every model). Found by the
pre-release default-library check before tagging.

An assertion between two reference types is a plain reinterpreting cast again, as before #775;
the layout check stays for implicit conversions (a call's argument, an assignment).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ASDAlexander77
ASDAlexander77 merged commit b4fd76a into main Nov 6, 2026
2 checks passed
@ASDAlexander77
ASDAlexander77 deleted the ref-assertion-reinterpret branch November 6, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant