Repository navigation
Android link test: every ABI a release ships, under every memory model - #822
Merged
Merged
Conversation
test-compile-android-link linked x86_64 only, under gc and own. It now links an executable and a shared library for arm64-v8a, armeabi-v7a and x86_64 under gc, rc, none and own (24 binaries) with the default library, collector and async runtime the release builds, and checks that each is an ELF file for its ABI's machine. It skips, as before, until all of them are built; the release step fails on a skip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release's Android link test covered x86_64 only, under
gcandown. It now covers every ABI a release ships, under every memory model.What
test-compile-android-linkdoes nowThe test links a small program twice: as an executable, and as a shared library with
--no-undefined.aarch64-linux-android29), armeabi-v7a (armv7a-linux-androideabi29) and x86_64 (x86_64-linux-android29).gc,rc,noneandown. That makes 24 binaries.e_machine: AArch64, ARM or x86-64. A link for the wrong architecture fails.As before, the test is skipped unless the NDK and all the libraries are present, and the release's "Test Compiler for Android" step fails on a skip. The release already builds every one of these libraries: all three ABIs in the collector and runtime scripts, and all ABIs and models in
build_android.bat. So no build step changes; only that step's comment does.Testing
Run locally with NDK r30:
ctest -C Release -R test-compile-android-passes both tests; the link test takes 3.2 s.It still only links; nothing runs on Android. A program that small pulls in only part of the default library, so a function Bionic lacks is caught only in the parts it links.
🤖 Generated with Claude Code