Repository navigation
Android emulator tests: the emulator start step polls without errexit - #828
Merged
Merged
Conversation
GitHub runs bash steps with -e -o pipefail, so the first boot poll - `adb shell` before the device is up - failed the assignment and ended the step with exit 1 and no message (manual run 43248917621; KVM was usable). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#827's new Start the emulator step failed with exit 1 and no message in manual run 43248917621. KVM was usable (
KVM (version 12) is installed and usable.).The cause: GitHub runs bash steps with
-e -o pipefail. The first boot poll,adb shell getprop sys.boot_completedbefore any device is up, fails, which failed the assignment and ended the step. The step now starts withset +e +o pipefail; its own checks stillexit 1with a message on a real failure.This PR changes the workflow, so its CI runs the emulator against the newest published release's package.
🤖 Generated with Claude Code