Repository navigation
Android: skip 00stdcall_winapi.ts, which calls the Windows API - #844
Merged
Merged
Conversation
The test #842 added declares GetCurrentProcessId and MulDiv from kernel32; ctest runs it on Windows only and the wasm runner skips it, but the Android runner tried to build it for every tester leg, and the four failed links failed the release's "Build Android tests" step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test #842 added declares
GetCurrentProcessIdandMulDivfrom kernel32. ctest runs it on Windows only and the wasm runner already skips it, but the Android runner built it for every tester leg (gc, rc, none, own). The four failed links failed the release's Build Android tests (x86_64) step (run 43483510331, v0.0-pre-alpha127).Adds it to
tslang/test/android/android_skips.txt; the runner'sloadSkipsreads it as a skip for every leg.🤖 Generated with Claude Code