Repository navigation
WeakRef<T> is the compiler's built-in; the gc-only link class becomes GcWeakLink - #102
Merged
Merged
Conversation
… GcWeakLink The compiler now has WeakRef<T> itself (gc, own and none), resolved before any declaration of the name. The library's collector-backed class stays for WeakMap and WeakSet only, renamed so it no longer shadows (or is shadowed by) the built-in. Needs the compiler's own-weakref change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to ASDAlexander77/TypeScriptCompiler#871: merge that PR first.
The compiler now has
WeakRef<T>built in, under gc, own and none, and resolves it before any declaration of the name. The library's gc-only, collector-backed class stays, becauseWeakMapandWeakSetkeep using it. It is renamedGcWeakLinkso it no longer shadows the built-in (or is shadowed by it). Theweakref_basictest comment is updated to match.Tested with the compiler branch: every test passes under gc, own, none and rc. The only tests not run are those skipped by design.
weakmap_weaksetandweakref_basicpass under gc.🤖 Generated with Claude Code