Repository navigation
Array<T>: a constructor taking the length - #40
Merged
Merged
Conversation
`new Array<int>(10)` makes an array of ten elements. It needs the compiler's constructor overloads (TypeScriptCompiler, constructor-overloads). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new Array<int>(10)makes an array of ten elements, all zero:Array<T>gets a second constructor,constructor(count: int = 0), next to the existingconstructor(private data: T[] = []). AT[]argument andnew Array<T>()still use the first one.Depends on ASDAlexander77/TypeScriptCompiler#696 (constructor overloads). Without it, this fails to compile with
can't resolve name: data.Tests
tests/array_count.ts. Passes under the JIT and as an--opt_level=3exe.array_splice,array_class_splice, and theTypedArraysubclass (super(data)) still pass.lib.generics.tswas copied into__buildby hand. The default library has not been rebuilt withbuild.bat, and the fulltests.ps1suite has not been run.🤖 Generated with Claude Code