Repository navigation
Conversation
The latency log is read for the tail ("is the 30-39 fps CEF cadence in the frame
interval tail, or in one stage?"), but the table stopped at p90 and printed max:
on a 31-frame run p90 says nothing about the one frame that took 300 ms, and a
300-frame Steam session has no usable 1% low at all.
Stages.rows() now carries p95_ms and p99_ms and the table prints both, so a
before/after reading of the same log gives the p95/p99 pair directly instead of a
median and an outlier. No other behaviour changes; the --json keys are additive.
latency_test.sh step 7 on this branch: 31 frames, 16 ms apart, one held 300 ms ->
stage n median ms p90 ms p95 ms p99 ms min max
server -> GPU done 31 0.44 0.58 0.83 210.74 0.07 300.61
(p99 210.74 ms is the held frame; p90 0.58 ms hid it.)
Author
|
@coderabbitai review |
Author
|
Requesting a review: this is ready and mergeable. CodeRabbit does not appear to be installed on this repo, so this is a ping for a human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tools/latency_report.pyis the reader forVKBRIDGE_LATLOG, and the question it gets asked is about the tail: on the CMF the Steam menu sits at a CEF-cadence-bound ~30-39 fps with commits 25-34 ms apart, while the bridge's own stages are small (fence wait 2.60 ms, render_scene 3.39 ms, acquire 0.13, present 0.44 of a ~31.8 ms frame, 2026-11-20,/tmp/opencode/two-track-plan.md). Answering "is the cadence in the frame-interval tail or inside one stage" needs percentiles past p90, and the plan's own acceptance test is before/after p95/p99 frame times.The table stopped at
median,p90,min,max. On a short logp90says nothing about the frame that took 300 ms, and on a long Steam sessionmaxis one outlier with no 1 % low next to it.Change
Stages.rows()gainsp95_msandp99_ms(samepct()interpolator already used for p50/p90), andtable()prints two more columns. Additive--jsonkeys; no other behaviour, no new switch, no change to what the server or client log.That row is
host/latency_test.shstep 7 on this branch: 31 frames 16 ms apart with the first one held 300 ms on the GPU. Before this change the same log readmedian 0.44, p90 0.58, max 300.61— the held frame was visible only asmax, and a subtler tail (say 60 ms on 1 frame in 50) was invisible entirely.Check
host/latency_test.sh→ 7/7 OK (step 7 both parses--jsonand prints the new columns; the assertion onmedian_msis unchanged).host/run_tests.sh latencystill fails with 6 steps identically on unmodified3cd7a2bin this container (itspresent_late_checkcore-dumps under the suite's Mali profile shim); run alone it is 7/7. Pre-existing, unrelated.lagprobe_testreadsmedian_msfrom--jsonand is unaffected (skipped here: noVKB_WINE_DIR).Not claimed
Nothing here was measured on a phone. This only makes the next device reading (one
vkbridge-latency.logfrom the CMF) give p95/p99 per stage.