Fix parallel build race for awsres - #400
Open
gc-iot wants to merge 1 commit into
Open
Conversation
Make build-awsres-tool-native depend on build-lib-native to prevent concurrent gprbuild invocations from operating on the same library build tree. Reproduced on Ubuntu 26.04 ARM64 (aarch64) under UTM virtualization using GCC/GNAT 17.0.0 experimental and GPRbuild 25.0w. Unpatched builds failed with make -j2, -j4 and -j10 with nondeterministic missing zlib objects, including uncompr.o, trees.o and inflate.o. A serial make -j1 build succeeded. Verified on TESTUDO: two clean make -j10 builds completed successfully after adding the dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make build-awsres-tool-native depend on build-lib-native to prevent concurrent gprbuild invocations from operating on the same library build tree.
Reproduced on Ubuntu 26.04 ARM64 (aarch64) under UTM virtualization using GCC/GNAT 17.0.0 experimental and GPRbuild 25.0w.
Unpatched builds failed with make -j2, -j4 and -j10 with nondeterministic missing zlib objects, including uncompr.o, trees.o and inflate.o. A serial make -j1 build succeeded.
Verified on TESTUDO: two clean make -j10 builds completed successfully after adding the dependency.