Skip to content

initial commit for shared probe modes in MAGPIE - #101

Open
a4894z wants to merge 3 commits into
mainfrom
magpie_shared_probe_modes
Open

a4894z wants to merge 3 commits into
mainfrom
magpie_shared_probe_modes

Conversation

@a4894z

@a4894z a4894z commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Features/fixes

Initial pull request for shared probe modes in MAGPIE.

I've tested this on experimental as well as simulated ptycho data, and the main issue I'm currently having is due to unconstrained pixels in "valid_pixel_mask".

Confirmed working with UNIFORM and RANDOM batching; doesn't work with COMPACT.

See attached pdf magpie_summary.pdf, slide 10 and onwards.

The main math change from the arxiv paper at

https://arxiv.org/html/2511.01793v2

is on slide 13 in magpie_summary.pdf

Claude also says prop 3.2 in the arxiv paper is now violated; need to chat with Wendy to see how significat this is.

Mentions

Ming Du (Argonne) and Borong Zhang (Georgia Tech)

Checklist (Don't skip!)

Have you...

  • Formatted your code properly adhering to PEP-8? Considering using RUFF to format your code automatically (https://docs.astral.sh/ruff/installation/).
  • Cleaned up your code to remove large commented-out blocks?
  • Properly documented any new API knobs and functions with non-trivial signatures?
  • Resolved all merge conflicts with the main branch?
  • Checked the diffs between your branch and the main branch to ensure that your changes are not introducing any regressions or unnecessary/irrelevant changes?
  • Checked the diffs to ensure your PR only includes one feature/fix? Multiple features/fixes/changes should be split into different PRs.
  • Added unit tests for new features if necessary?

magpie_summary.pdf

2511.01793v2.pdf

below is MAGPIE y_pred (computed exit wave for a representative scan position) assuming no TV in PtyChi...notice the poorly scaled band in the bottom half; this issue exists in LSQML and other solvers as well so I'm leaving it unaddressed for now.

y_pred_250

below is y_pred with TV turned on.

y_pred_525

@a4894z a4894z assigned a4894z and unassigned a4894z Nov 10, 2026
@a4894z
a4894z requested a review from mdw771 November 10, 2026 21:30

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant