Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features/fixes
Initial pull request for shared probe modes in MAGPIE.
I've tested this on experimental as well as simulated ptycho data, and the main issue I'm currently having is due to unconstrained pixels in "valid_pixel_mask".
Confirmed working with UNIFORM and RANDOM batching; doesn't work with COMPACT.
See attached pdf magpie_summary.pdf, slide 10 and onwards.
The main math change from the arxiv paper at
https://arxiv.org/html/2511.01793v2
is on slide 13 in magpie_summary.pdf
Claude also says prop 3.2 in the arxiv paper is now violated; need to chat with Wendy to see how significat this is.
Mentions
Ming Du (Argonne) and Borong Zhang (Georgia Tech)
Checklist (Don't skip!)
Have you...
magpie_summary.pdf
2511.01793v2.pdf
below is MAGPIE y_pred (computed exit wave for a representative scan position) assuming no TV in PtyChi...notice the poorly scaled band in the bottom half; this issue exists in LSQML and other solvers as well so I'm leaving it unaddressed for now.
below is y_pred with TV turned on.